fix(inbox): restore Scout in the source filter dropdown#2587
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix(inbox): restore Scout in the source ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Inbox 2.0 (#2547) rebuilt the source filter from a new
INBOX_SOURCE_OPTIONSlist and dropped thesignals_scoutentry added in #2505. Scout-sourced reports could no longer be filtered: the dropdown had no Scout row, and a persisted Scout filter rendered its chip with the rawsignals_scoutvalue because the label lookup falls back to the raw string when no option matches.Changes
signals_scout, compass icon) back toINBOX_SOURCE_OPTIONSinpackages/ui/src/features/inbox/filterOptions.tsx, so the source dropdown lists Scout again and the filter chip reads "Scout".CLAUDE.mdrule that said "Do not add Scout UI until a corresponding backend exists in this repo" — it reads as if Scout shouldn't appear anywhere, which is likely how the filter entry got dropped. It now states Scout is a real Cloud source product that must stay covered in filter options, source meta, and signal cards, and scopes the prohibition to Scout management UI (fleet configuration, run history).Scout coverage that survived 2.0 and is unchanged here:
SOURCE_PRODUCT_METAbadges and the scout-name source line onSignalCard(#2538).How did you test this?
pnpm --filter @posthog/ui typecheckpasses.pnpm --filter @posthog/ui test— 690 tests pass.Automatic notifications