Skip to content

chore: Sweep dead code from the package-split refactor#2662

Open
charlesvien wants to merge 17 commits into
mainfrom
chore/dead-code-sweep
Open

chore: Sweep dead code from the package-split refactor#2662
charlesvien wants to merge 17 commits into
mainfrom
chore/dead-code-sweep

Conversation

@charlesvien

@charlesvien charlesvien commented Jun 14, 2026

Copy link
Copy Markdown
Member

Problem

The big package-split refactor left a ton of dead code lying around, it pollutes agent context on every read. This is a knip + ts-morph dynamic-harness sweep to clear it out.

Changes

  1. Deleted ~340 dead exported declarations (values + types) across 13 packages
  2. Removed dead files and orphaned types; collapsed redundant export aliases
  3. Removed unused deps/devDeps and declared 12 previously-undeclared (hoisted) deps
  4. Fixed knip blind spots: dist-resolution false positives, un-ignored apps/web, protected native deps
  5. Net: 125 files, +109 / −3,503 lines

How did you test this?

All run locally on this branch:

  • pnpm typecheck — green across all 22 workspaces (incl. apps/web, the cross-package gate)
  • pnpm lint (biome) — clean
  • pnpm build — green (8/8, incl. the Electron package)
  • pnpm test — green (18/18 packages; workspace-server DB tests pass after rebuilding better-sqlite3 for the Node 26 ABI)
  • Every package was committed behind its own typecheck/test gate. A knip → ts-morph harness with an external-usage guard ensured only genuinely 0-reference symbols were deleted; spot-checked that the remaining knip flags are live over-exports / dist false-positives, not dead code.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

@github-actions

Copy link
Copy Markdown

React Doctor could not complete this scan.

No React dependency found in /tmp/react-doctor-baseline-8OxTLw/package.json. Add "react" to dependencies (or peerDependencies) and re-run.

Reviewed by React Doctor for commit 0877f5d.

@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jun 14, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much faff.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant