Skip to content

fix(ci): Bump react-doctor to 0.5.4 to fix monorepo scan#2664

Merged
charlesvien merged 1 commit into
mainfrom
fix/react-doctor-monorepo
Jun 14, 2026
Merged

fix(ci): Bump react-doctor to 0.5.4 to fix monorepo scan#2664
charlesvien merged 1 commit into
mainfrom
fix/react-doctor-monorepo

Conversation

@charlesvien

Copy link
Copy Markdown
Member

Problem

React Doctor cannot complete on this pnpm monorepo. Version 0.4.2 roots its diff baseline at the repo root, whose package.json has no React dependency, so every PR scan crashes with NoReactDependencyError before any file is checked.

Changes

  1. Bump the pinned react-doctor from 0.4.2 to 0.5.4 in .github/workflows/react-doctor.yml. 0.5.4 fixes the monorepo baseline so the scan maps changed files to their workspace packages (packages/ui, apps/*, ...) instead of the React-less repo root.

How did you test this?

Reproduced the exact CI invocation locally (same base SHA, changed-files list and flags):

  1. 0.4.2 reproduces the reported failure: NoReactDependencyError on the baseline temp dir.
  2. 0.5.4 passes: ok: true, error: null, exit code 0. It correctly scans the changed React files in packages/ui and surfaces one jsx-no-jsx-as-prop warning, which does not block under --blocking error.
  3. Confirmed CI can still fetch 0.5.4: min-release-age is an npm 11+ feature and CI's node-22 ships npm 10, which ignores it (the same reason the recent 0.4.2 downloaded there).

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 8093760.

@greptile-apps

greptile-apps Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "bump react-doctor to 0.5.4 for monorepo ..." | Re-trigger Greptile

@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jun 14, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR modifies a CI workflow file, which is caught by the infra/CI deny-list. CI workflow changes require human review to verify the new tool version is safe and behaves as expected.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jun 14, 2026
@charlesvien charlesvien merged commit 3ae1fd4 into main Jun 14, 2026
23 checks passed
@charlesvien charlesvien deleted the fix/react-doctor-monorepo branch June 14, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant