fix(ci): Bump react-doctor to 0.5.4 to fix monorepo scan#2664
Merged
Conversation
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "bump react-doctor to 0.5.4 for monorepo ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
React Doctor cannot complete on this pnpm monorepo. Version 0.4.2 roots its diff baseline at the repo root, whose
package.jsonhas no React dependency, so every PR scan crashes withNoReactDependencyErrorbefore any file is checked.Changes
react-doctorfrom0.4.2to0.5.4in.github/workflows/react-doctor.yml. 0.5.4 fixes the monorepo baseline so the scan maps changed files to their workspace packages (packages/ui,apps/*, ...) instead of the React-less repo root.How did you test this?
Reproduced the exact CI invocation locally (same base SHA, changed-files list and flags):
0.4.2reproduces the reported failure:NoReactDependencyErroron the baseline temp dir.0.5.4passes:ok: true,error: null, exit code0. It correctly scans the changed React files inpackages/uiand surfaces onejsx-no-jsx-as-propwarning, which does not block under--blocking error.0.5.4:min-release-ageis an npm 11+ feature and CI's node-22 ships npm 10, which ignores it (the same reason the recent0.4.2downloaded there).Automatic notifications