Classify Codex exec failures separately#60
Conversation
Co-Authored-By: Codex <noreply@openai.com>
🤖 Codex PR ReviewPlease ensure a human reviewer checks this PR before merging. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30ed78e205
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if "codex exec failed" in text: | ||
| return _classify_codex_exec_failure(text) |
There was a problem hiding this comment.
Preserve auth classification for Codex exec errors
This early return bypasses the broader auth/config signals below for every codex exec failed stderr. If the Codex CLI reports auth problems as Unauthorized, Forbidden, api key is required, missing token, etc. without the exact 401 unauthorized/403 forbidden/invalid api key phrases in the new helper, the service records unknown_failure; the monthly bridge then treats a service auth/config outage as a normal job failure and can run API fallback instead of failing closed with an infra comment. Please keep the existing auth signals available for genuine Codex stderr after filtering the source-code false positives.
Useful? React with 👍 / 👎.
Co-Authored-By: Codex <noreply@openai.com>
Summary
codex exec failedoutput separately from service auth/config errorsnot allowedorallowlistbeing treated as auth failuresTests