Add QPK dependency for monthly publish#99
Conversation
a0002b4 to
4de51f0
Compare
4de51f0 to
d5ef766
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5ef7666d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - name: Authenticate to Google Cloud | ||
| uses: google-github-actions/auth@v2 | ||
| uses: google-github-actions/auth@v3 |
There was a problem hiding this comment.
Re-authenticate closer to the publish step
With the new Workload Identity Federation setup, the google-github-actions/auth docs warn that the GitHub OIDC token and derived credentials expire after about 5 minutes; in this workflow the only Google Cloud work happens later in Publish Production v1 Release, after dependency install, history download, and the monthly shadow build. When those pre-publish steps take more than a few minutes, the publish script will try to upload to GCS/Firestore with expired ADC credentials, so move this auth step immediately before publishing or refresh credentials there.
Useful? React with 👍 / 👎.
Summary
Root cause
After the GCP WIF condition was fixed, the monthly publish run advanced to real release publishing and failed with
ModuleNotFoundError: No module named quant_platform_kit.src/publish.pyimportsquant_platform_kit.cloudfor GCS and Firestore writes, but the monthly publish dependency install only used requirements-lock.txt, which did not include QPK.Verification