Skip to content

Add QPK dependency for monthly publish#99

Merged
Pigbibi merged 1 commit into
mainfrom
codex/add-qpk-publish-dependency-20260701
Jul 1, 2026
Merged

Add QPK dependency for monthly publish#99
Pigbibi merged 1 commit into
mainfrom
codex/add-qpk-publish-dependency-20260701

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add quant-platform-kit to requirements and requirements-lock for real monthly publish
  • upgrade the monthly publish WIF auth action to v3
  • update workflow config tests to require WIF and lock the QPK dependency

Root cause

After the GCP WIF condition was fixed, the monthly publish run advanced to real release publishing and failed with ModuleNotFoundError: No module named quant_platform_kit. src/publish.py imports quant_platform_kit.cloud for GCS and Firestore writes, but the monthly publish dependency install only used requirements-lock.txt, which did not include QPK.

Verification

  • git diff --check
  • python3 -m unittest tests.test_monthly_publish_workflow_config -v
  • uv run --with pip python -m pip install --dry-run -r requirements-lock.txt

@Pigbibi Pigbibi force-pushed the codex/add-qpk-publish-dependency-20260701 branch from a0002b4 to 4de51f0 Compare July 1, 2026 08:48
@Pigbibi Pigbibi force-pushed the codex/add-qpk-publish-dependency-20260701 branch from 4de51f0 to d5ef766 Compare July 1, 2026 08:51
@Pigbibi Pigbibi merged commit ff83a08 into main Jul 1, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/add-qpk-publish-dependency-20260701 branch July 1, 2026 08:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5ef7666d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


- name: Authenticate to Google Cloud
uses: google-github-actions/auth@v2
uses: google-github-actions/auth@v3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Re-authenticate closer to the publish step

With the new Workload Identity Federation setup, the google-github-actions/auth docs warn that the GitHub OIDC token and derived credentials expire after about 5 minutes; in this workflow the only Google Cloud work happens later in Publish Production v1 Release, after dependency install, history download, and the monthly shadow build. When those pre-publish steps take more than a few minutes, the publish script will try to upload to GCS/Firestore with expired ADC credentials, so move this auth step immediately before publishing or refresh credentials there.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant