Skip to content

chore: sync QPK constraints with QSL bundle 2026.07.2#178

Merged
Pigbibi merged 2 commits into
mainfrom
codex/qpk-constraints-2026072
Jul 4, 2026
Merged

chore: sync QPK constraints with QSL bundle 2026.07.2#178
Pigbibi merged 2 commits into
mainfrom
codex/qpk-constraints-2026072

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Updates QPK constraints.txt after the QSL 2026.07.2 downstream merge wave.\n\nValidation:\n- git diff --check\n- python3 /Users/lisiyi/Projects/QuantRuntimeSettings/scripts/check_qsl_compat.py --repo-root . --compat-root /Users/lisiyi/Projects/QuantRuntimeSettings --json

@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi force-pushed the codex/qpk-constraints-2026072 branch from a08647b to 49298bb Compare July 4, 2026 23:22
@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a08647b9e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread constraints.txt Outdated
Comment on lines +4 to +8
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.gitc81901160c5b31127a27dba1c63944933fb6bf
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.gitc0dbac5d47546f46d7c08ca2bf080010aa09695
hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.gite8f28d171ed4f509b3fcbb790738fc1a7fbd9
cn-equity-strategies @ git+https://github.com/QuantStrategyLab/CnEquityStrategies.git
crypto-strategies @ git+https://github.com/QuantStrategyLab/CryptoStrategies.gite8f0541372b0a658f5685f256cebde361d2563a

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the git ref separator in constraints

When these constraints are consumed by pip (for example the downstream compatibility check in .github/workflows/update-qpk-pin.yml installs strategy packages with -c constraints.txt), the missing @ after .git makes pip treat the SHA as part of the repository URL; I verified us-equity-strategies is cloned from https://github.com/QuantStrategyLab/UsEquityStrategies.gitc0db... instead of ...git@c0db.... The CN entry also lost its ref entirely, so these constraints no longer provide fetchable/pinned package refs and downstream installs will fail or drift.

Useful? React with 👍 / 👎.

Comment thread constraints.txt Outdated
hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@a72595ae8b6e6d49250dc9cb77da0275523d94dd
cn-equity-strategies @ git+https://github.com/QuantStrategyLab/CnEquityStrategies.git@026d5b4479340901d2a5aa5fdc77ea47c05611ce
crypto-strategies @ git+https://github.com/QuantStrategyLab/CryptoStrategies.git@746440683f63c3f696a12278aff9c7af030700c2
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.gitc81901160c5b31127a27dba1c63944933fb6bf

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the QPK constraint aligned with QPK_PIN

For consumers that combine the canonical QPK_PIN with this live constraints file, this line now points at a different and truncated QPK ref: QPK_PIN still contains 37c81901160c5b31127a27dba1c63944933fb6bf, while the constraint drops the leading 37 and git cat-file cannot resolve c81901160c5b31127a27dba1c63944933fb6bf in this repo. Even after restoring the URL separator, the self-constraint would conflict with the pin mechanism and fail to fetch the intended QPK commit.

Useful? React with 👍 / 👎.

Co-Authored-By: Codex <noreply@openai.com>
@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Pigbibi Pigbibi merged commit cc1e09e into main Jul 4, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/qpk-constraints-2026072 branch July 4, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant