Add live candidate notification events#180
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34e07328ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
|
|
||
| def _build_alert_key(strategy_profile: str, domain: str, stage: str, approval_action: str) -> str: | ||
| return f"lifecycle/live_candidate/{domain}/{strategy_profile}/{stage}/{approval_action}" |
There was a problem hiding this comment.
When these events are routed through the existing notification stores, alert_key is the duplicate marker, but this key only varies by domain/profile/stage/action. If a strategy submits a later evidence package with the same outcome, such as a second hold after some sections were corrected or a refreshed approve, it reuses the previous marker and can be skipped as a duplicate, so operators may never see the new gate result. Include a submission timestamp or package digest in the key to distinguish distinct evidence packages.
Useful? React with 👍 / 👎.
1 participant
Adds lifecycle live-candidate notification event builder and exports it from strategy_lifecycle.\n\nValidation: PYTHONPATH=src python3 -m pytest -q (454 passed, 1 skipped).