[codex] add dependency matrix sync and CI gates#142
Conversation
Co-Authored-By: Codex <noreply@openai.com>
🤖 Codex PR ReviewPlease ensure a human reviewer checks this PR before merging. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c03b7fe08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rendered_payload = json.dumps(generated_payload, ensure_ascii=False, indent=2) | ||
| print(rendered_payload) | ||
| if args.sync: | ||
| args.matrix.write_text(rendered_payload + "\n", encoding="utf-8") |
There was a problem hiding this comment.
Guard --sync against empty consumer scans
When --sync is run from a standalone QuantRuntimeSettings checkout or before sibling consumer repos are cloned, collect_dependency_pins_from_projects returns no pins and this line overwrites internal_dependency_matrix.json with dependencies: []. I checked the follow-up strict path: with an empty matrix, --strict --require-consumer-files checks zero files and exits 0, so a mistaken sync can remove all matrix coverage without CI catching it. Please fail or require the expected consumers before writing.
Useful? React with 👍 / 👎.
Summary
Validation