Skip to content

[codex] add dependency matrix sync and CI gates#142

Merged
Pigbibi merged 1 commit into
mainfrom
codex/dependency-gate-ci-20260702
Jul 2, 2026
Merged

[codex] add dependency matrix sync and CI gates#142
Pigbibi merged 1 commit into
mainfrom
codex/dependency-gate-ci-20260702

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add generated/sync workflow for internal dependency matrix from local consumer pins.
  • Document the matrix regeneration flow in English and Chinese.
  • Add package README metadata and actionlint CI coverage.

Validation

  • actionlint
  • git diff --check
  • python3 -m pytest python/tests/test_internal_dependency_matrix.py python/tests/test_gate_codex_app_review.py -q
  • python3 python/scripts/check_internal_dependency_matrix.py --strict --require-consumer-files
  • python -m build ./python

Co-Authored-By: Codex <noreply@openai.com>
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

🤖 Codex PR Review

⚠️ Review skipped: The Codex review could not be completed.

No Codex service URL or API key configured. Set CODEX_AUDIT_SERVICE_URL, ANTHROPIC_API_KEY, or OPENAI_API_KEY.

Please ensure a human reviewer checks this PR before merging.

@Pigbibi Pigbibi merged commit a33f86e into main Jul 2, 2026
8 checks passed
@Pigbibi Pigbibi deleted the codex/dependency-gate-ci-20260702 branch July 2, 2026 09:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c03b7fe08

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

rendered_payload = json.dumps(generated_payload, ensure_ascii=False, indent=2)
print(rendered_payload)
if args.sync:
args.matrix.write_text(rendered_payload + "\n", encoding="utf-8")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Guard --sync against empty consumer scans

When --sync is run from a standalone QuantRuntimeSettings checkout or before sibling consumer repos are cloned, collect_dependency_pins_from_projects returns no pins and this line overwrites internal_dependency_matrix.json with dependencies: []. I checked the follow-up strict path: with an empty matrix, --strict --require-consumer-files checks zero files and exits 0, so a mistaken sync can remove all matrix coverage without CI catching it. Please fail or require the expected consumers before writing.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant