Skip to content

Align Binance combo R5 cash-cap settings#156

Merged
Pigbibi merged 1 commit into
mainfrom
chore/binance-combo-r5-settings
Jul 4, 2026
Merged

Align Binance combo R5 cash-cap settings#156
Pigbibi merged 1 commit into
mainfrom
chore/binance-combo-r5-settings

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update Binance crypto_combo example to R5 cash-cap shadow parameters
  • sync BinancePlatform crypto-strategies pin in internal dependency matrix

Validation

  • python3 -m unittest discover -s python/tests -p 'test*.py'
  • python3 -m ruff check .
  • git diff --check

Co-Authored-By: Codex <noreply@openai.com>
@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

🤖 Codex PR Review

⚠️ Review skipped: The Codex review could not be completed.

No Codex service URL or API key configured. Set CODEX_AUDIT_SERVICE_URL, ANTHROPIC_API_KEY, or OPENAI_API_KEY.

Please ensure a human reviewer checks this PR before merging.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea8fc2b7f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"package": "crypto-strategies",
"source_repo": "CryptoStrategies",
"ref": "6fe378adc6602412a1763ca115b5d17d311a65a9"
"ref": "746440683f63c3f696a12278aff9c7af030700c2"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align requirements.txt pin with BinancePlatform

When the dependency matrix checker runs with the BinancePlatform sibling checkout, it compares this row against BinancePlatform/requirements.txt. I checked the current BinancePlatform requirements.txt, and it still pins crypto-strategies at ccd3e8e25be285f72c92eacc72f7734ae8043fe3 while only requirements-lock.txt is on 746440...; this new row will therefore produce a ref mismatch for BinancePlatform/requirements.txt under check_internal_dependency_matrix.py --strict until the consumer file is updated or this matrix row is kept on the actual requirements pin.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit aca2c10 into main Jul 4, 2026
10 checks passed
@Pigbibi Pigbibi deleted the chore/binance-combo-r5-settings branch July 4, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant