Align Binance combo R5 cash-cap settings#156
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
🤖 Codex PR ReviewPlease ensure a human reviewer checks this PR before merging. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea8fc2b7f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "package": "crypto-strategies", | ||
| "source_repo": "CryptoStrategies", | ||
| "ref": "6fe378adc6602412a1763ca115b5d17d311a65a9" | ||
| "ref": "746440683f63c3f696a12278aff9c7af030700c2" |
There was a problem hiding this comment.
Align requirements.txt pin with BinancePlatform
When the dependency matrix checker runs with the BinancePlatform sibling checkout, it compares this row against BinancePlatform/requirements.txt. I checked the current BinancePlatform requirements.txt, and it still pins crypto-strategies at ccd3e8e25be285f72c92eacc72f7734ae8043fe3 while only requirements-lock.txt is on 746440...; this new row will therefore produce a ref mismatch for BinancePlatform/requirements.txt under check_internal_dependency_matrix.py --strict until the consumer file is updated or this matrix row is kept on the actual requirements pin.
Useful? React with 👍 / 👎.
Summary
Validation