Skip to content

[codex] Fix settings profile fallback display#157

Merged
Pigbibi merged 1 commit into
mainfrom
codex/settings-profile-display-alignment
Jul 4, 2026
Merged

[codex] Fix settings profile fallback display#157
Pigbibi merged 1 commit into
mainfrom
codex/settings-profile-display-alignment

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Align Strategy Switch frontend fallback profile labels with strategy-profiles.example.json.
  • Add missing cn_industry_etf_rotation fallback profile so offline/API fallback display matches the catalog.
  • Avoid false pending margin changes on platforms without margin policy support, such as Binance and QMT.

Root cause

  • The live /api/strategy-profiles catalog was correct, but the app's local fallback list and local labels had drifted from the canonical strategy profile catalog.
  • Pending cash-only execution comparison still ran for non-margin platforms when no cash-only input should exist.

Validation

  • python3 python/scripts/build_config.py --check
  • node tests/strategy_switch_worker_validation.mjs
  • node --check for page_asset.js, strategy_profiles_asset.js, app_css.js, app_js.js, and worker.js
  • git diff --check HEAD~1 HEAD
  • Manual Chrome login verification of Settings profile display for Binance, QMT, and IBKR.

@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

🤖 Codex PR Review

⚠️ Review skipped: The Codex review could not be completed.

No Codex service URL or API key configured. Set CODEX_AUDIT_SERVICE_URL, ANTHROPIC_API_KEY, or OPENAI_API_KEY.

Please ensure a human reviewer checks this PR before merging.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi force-pushed the codex/settings-profile-display-alignment branch from 5f5e9df to 6cbdf92 Compare July 4, 2026 15:35
@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Pigbibi Pigbibi merged commit 21add24 into main Jul 4, 2026
8 checks passed
@Pigbibi Pigbibi deleted the codex/settings-profile-display-alignment branch July 4, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant