[bsp][imxrt1180-nxp-evk]add TIMER support by HonestQiao · Pull Request #11511 · RT-Thread/rt-thread

HonestQiao · 2026-06-24T00:36:11Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

add TIMER support

你的解决方案是什么 (what is your solution)

add TIMER support

请提供验证的bsp和config (provide the config and bsp)

BSP: bsp\nxp\imx\imxrt\imxrt1180-nxp-evk\cm33
BSP: bsp\nxp\imx\imxrt\imxrt1180-nxp-evk\cm7

.config: bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm33/board/Kconfig
.config: bsp/nxp/imx/imxrt/imxrt1180-nxp-evk/cm7/board/Kconfig

        menuconfig BSP_USING_CLOCK_TIMER
            bool "Enable GPT"
            default n
            select RT_USING_CLOCK_TIME
            if BSP_USING_CLOCK_TIMER
                config BSP_USING_CLOCK_TIMER1
                    bool "Enable GPT1"
                    default n

                config BSP_USING_CLOCK_TIMER2
                    bool "Enable GPT2"
                    default n
            endif

action: done

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

[ x ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

[ x ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
[ x ] 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
[ x ] 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
[ x ] 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
[ x ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
[ x ] 代码是高质量的 Code in this PR is of high quality
[ x ] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2026-06-24T00:36:40Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：imxrt1180-nxp-evk-timer-v1
设置PR number为 \ Set the PR number to：11511

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 imxrt1180-nxp-evk-timer-v1 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the imxrt1180-nxp-evk-timer-v1 branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

Rbb666 · 2026-06-27T03:36:15Z

main.c 不用添加用户代码

Rbb666 · 2026-06-27T03:36:52Z

    # CPPDEFINES += ['FSL_SDK_DRIVER_QUICK_ACCESS_ENABLE=1']

+if GetDepend(['BSP_USING_CLOCK_TIMER']):
+    src += ['../packages/nxp-imxrt-sdk-latest/MIMXRT1180/MIMXRT1189/drivers/fsl_gpt.c']


这种方式不太正确，应该写道软件包的scons脚本中

已修改。软件包中也提交了：nxp-imxrt-sdk/pull/7

Rbb666 · 2026-06-27T03:37:19Z

同上，测试代码不需要添加到main.c

已修改。

github-actions · 2026-06-27T03:44:49Z

MemBrowse Memory Report

No memory changes detected for:

…script

nxp-ran · 2026-07-03T03:57:35Z

Hi @Rbb666,
这边测试是通过的，麻烦merge

Rbb666 · 2026-07-04T08:42:22Z

    if (ret != RT_EOK)
    {
        LOG_E("gpt1 register failed\n");
+        if (err == RT_EOK)


没看懂这块代码添加的意义，用 res 返回不就可以了吗？为什么要添加一个 err？

因为有两个GPT可以初始化，这里如果gpt1初始化失败了，gpt2会继续初始化，但返回gpt1的错误状态。

可供考虑的：

gpt1失败，gpt2继续初始化，但返回gpt1错误状态【当前方案】

gpt1初始化失败，不继续初始化gpt2，返回gpt1错误状态【疑问对应方案】

@Rbb666 建议采用哪一种？

没修改之前，如果gpt1失败也是可以继续初始化后面的gpt吧，没看到有返回的处理呢？

已处理，按照原有逻辑。

Rbb666 · 2026-07-04T08:43:51Z

 #include <rtdevice.h>

-int rt_hw_wdt_init(void);
+int rt_hw_clock_timer_init(void);


不建议添加单独的头文件，驱动层使用驱动级别的自动初始化即可

已处理。

[bsp][imxrt1180-nxp-evk]add TIMER support

81d45ba

HonestQiao requested a review from Rbb666 as a code owner June 24, 2026 00:36

github-actions Bot added BSP: NXP Code related with NXP BSP labels Jun 24, 2026

[bsp][imxrt1180-nxp-evk]update TIMER support

dd5e61d

Rbb666 requested changes Jun 27, 2026

View reviewed changes

HonestQiao added 2 commits July 3, 2026 08:41

[bsp][imxrt1180-nxp-evk] move fsl_gpt.c inclusion to SDK package SCon…

77cdf56

…script

[bsp][imxrt1180-nxp-evk] restore main.c to original Hello_World version

1c88bdb

Rbb666 reviewed Jul 4, 2026

View reviewed changes

Rbb666 requested changes Jul 4, 2026

View reviewed changes

[bsp][imxrt1180-nxp-evk] remove libraries/drivers/drv_timer.h

27f95df

HonestQiao requested a review from Rbb666 July 8, 2026 01:17

[bsp][imxrt1180-nxp-evk]update TIMER support

ea7b2ea

Uh oh!

Conversation

HonestQiao commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions Bot commented Jun 24, 2026

🛠 操作步骤 | Steps

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 27, 2026

MemBrowse Memory Report

Uh oh!

nxp-ran commented Jul 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HonestQiao commented Jun 24, 2026 •

edited

Loading