fix: fix disable orphans handler to account for keyboard inserts#10069
Open
maribethb wants to merge 1 commit into
Open
fix: fix disable orphans handler to account for keyboard inserts#10069maribethb wants to merge 1 commit into
maribethb wants to merge 1 commit into
Conversation
gonfunko
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10068
Proposed Changes
disableOrphanslistener also listen to drag end eventsReason for Changes
For keyboard inserts from the flyout, a move event that has dragging = false is not always fired. If you insert a block from flyout without ever moving it (e.g. don't hit the arrow keys, don't enable grid snapping) then there is (correctly, arguably, since no move is happening) no move event, only a drag end.
This resulted in the newly created orphan block not being disabled.
Test Coverage
added
Documentation
Additional Information