Re-add Semantic Logger + fix for Puma in Cluster mode#884
Open
mwtrew wants to merge 4 commits into
Open
Conversation
This missing config meant Semantic Logger was not working in prod, where we use Puma in Cluster mode. See https://logger.rocketjob.io/forking.html#puma
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures Semantic Logger appenders are correctly re-opened after Puma forks worker processes in clustered mode so logging works in production.
Changes:
- Adds a Puma worker lifecycle hook intended to call
SemanticLogger.reopenafter forking. - Minor whitespace changes at the end of
config/puma.rb.
Comments suppressed due to low confidence (1)
config/puma.rb:58
- There are extra blank lines (and trailing whitespace) at the end of the file; this will typically trip whitespace/style checks and adds noise to diffs.
# Allow puma to be restarted by `bin/rails restart` command.
plugin :tmp_restart
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test coverage91.97% line coverage reported by SimpleCov. |
## Status - Related to RaspberryPiFoundation/digital-editor-issues#1455 ## What's changed? - Adds the Semantic Logging gem and uses it to make log messages more useful. See a comparison [here](https://logger.rocketjob.io/rails.html#configuration). - This includes controller and action names by default. - In the production environment only, logs are structured in JSON-format to make filtering easier in BetterStack. - Example: [filtering down to GET requests on the FeaturesController](https://telemetry.betterstack.com/team/t62404/tail?s=l314881&q=message.payload.controller%3D%22Api%3A%3AFeaturesController%22%20message.payload.method%3D%22GET%22&a=1781695637116522.107740926). - _The change in `application.rb` looks like it also enables JSON logging in non-prod environments, however this only applies to the log files written to disk, not the logging output in standard out._ - Disables Flipper logging, which was at DEBUG level with no clear way of changing the level. ## Steps to perform after deploying to production None.
mwtrew
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This missing config meant Semantic Logger was not working in prod, where we use Puma in Cluster mode.
See https://logger.rocketjob.io/forking.html#puma
Status
What's changed?
Steps to perform after deploying to production
None