Skip to content

Fix Heroku review app deployments#898

Merged
patch0 merged 4 commits into
mainfrom
remove-postgres-14-requirement
Jun 26, 2026
Merged

Fix Heroku review app deployments#898
patch0 merged 4 commits into
mainfrom
remove-postgres-14-requirement

Conversation

@patch0

@patch0 patch0 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Status

What's changed?

  • Updates app.json to remove requirement for Postgres 14
  • Adds in some other env variables to make review apps work more easily (bypass auth, sentry env, no salesforce)
  • Adds in the ruby buildpack explicitly
  • Seeds the database after deploy

Steps to perform after deploying to production

Doesn't affect prod 🤞🏻

@cla-bot cla-bot Bot added the cla-signed label Jun 26, 2026
copied from clubs-api
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

Test coverage

91.97% line coverage reported by SimpleCov.
Run: https://github.com/RaspberryPiFoundation/editor-api/actions/runs/28241055356

@patch0 patch0 temporarily deployed to editor-api-p-remove-pos-zvr0z1 June 26, 2026 11:49 Inactive
@patch0 patch0 changed the title Test branch to see if this works Fix Heroku review app deployments Jun 26, 2026
@patch0 patch0 marked this pull request as ready for review June 26, 2026 11:55
Copilot AI review requested due to automatic review settings June 26, 2026 11:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f84b451. Configure here.

Comment thread app.json

@mwtrew mwtrew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this :)

One thing to note, we might also need to change config.host to use HEROKU_APP_NAME in this case, like ExCS have (1, 2)

@patch0 patch0 temporarily deployed to editor-api-p-remove-pos-4trocn June 26, 2026 13:26 Inactive
@patch0 patch0 enabled auto-merge (squash) June 26, 2026 13:29
@patch0 patch0 merged commit 0e076e7 into main Jun 26, 2026
6 checks passed
@patch0 patch0 deleted the remove-postgres-14-requirement branch June 26, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants