Skip to content

Add extra required data to the track_event call when creating a school #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jamiebenstead wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add extra required data to the track_event call when creating a school #899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/controllers/api/schools_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ def create

if result.success?
@school = result[:school]
track_event('School - Created', school_id: @school.id)
track_event(
'School - Created',
school_id: @school.id,
first_landing_page: params[:first_landing_page],
marketing_parameters: marketing_parameters

@zetter-rpf zetter-rpf Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it would be easier to query in the data warehouse if all of the event properties were at the same level. It might just be harder to document and query if some are nested inside other attributes. This means we could query on events.properties['utm_source'] rather than events.properties['marketing_params']['utm_source'].

You should be able to do this by spatting the marketing parameters:

track_event('School - Created', **marketing_parameters, @school.id:, first_landing_page: params[:first_landing_page])

)
render :show, formats: [:json], status: :created
else
render json: {
Expand Down Expand Up @@ -77,6 +82,10 @@ def import

private

def marketing_parameters
params[:marketing_parameters]&.permit!&.to_h
end

def create_params
params.expect(
school: %i[name
Expand Down
Loading