Storage: add VirtualMachineBackup and VirtualMachineBackupTracker resources#2745
Storage: add VirtualMachineBackup and VirtualMachineBackupTracker resources#2745dalia-frank wants to merge 3 commits into
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughAdds Changesbackup.kubevirt.io Resource Definitions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ocp_resources/virtual_machine_backup_tracker.py`:
- Line 1: The header marker on line 1 in virtual_machine_backup_tracker.py does
not conform to the project's class-generator convention for ocp_resources.
Update the generator template (located in the class-generator tool referenced in
the comment) to use the correct start marker format as specified in the project
coding guidelines, then regenerate the virtual_machine_backup_tracker.py file
using the class-generator to ensure the generated-section tooling and review
behavior remains consistent with repository standards.
In `@ocp_resources/virtual_machine_backup.py`:
- Line 1: The generated-code start marker comment in virtual_machine_backup.py
uses a non-standard generator URL that does not match the repository standards
required for files in the ocp_resources directory. Update the class-generator
template to emit the correct repository-standard generated-code start marker,
then regenerate the virtual_machine_backup.py file to replace the current
marker, rather than manually editing the generated output.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f02901a6-0bcd-4a33-a4e0-39b14c879a7c
⛔ Files ignored due to path filters (3)
class_generator/schema/__cluster_version__.txtis excluded by!class_generator/schema/**class_generator/schema/__resources-mappings.json.gzis excluded by!**/*.gz,!class_generator/schema/**class_generator/schema/_definitions.jsonis excluded by!class_generator/schema/**
📒 Files selected for processing (3)
ocp_resources/resource.pyocp_resources/virtual_machine_backup.pyocp_resources/virtual_machine_backup_tracker.py
|
/verified |
|
/retest security-committer-identity |
6c750a3 to
8ba49d9
Compare
|
Clean rebase detected — no code changes compared to previous head ( |
2277040 to
62d66a1
Compare
|
Clean rebase detected — no code changes compared to previous head ( |
|
/approve |
|
/verified |
|
Clean rebase detected — no code changes compared to previous head ( |
|
/verified |
|
@dalia-frank please resolve the conflicts and rebase the PR |
07dab22 to
a7b30cb
Compare
Add generated backup.kubevirt.io resources with Push/Pull mode constants and update class-generator schema for the new CRDs. Signed-off-by: Dalia Frank <dfrank@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Pre-commit hook detected missing newlines in schema files. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
a7b30cb to
077ae6e
Compare
077ae6e to
7e51fe8
Compare
|
/verified |
Short description:
Add generated backup.kubevirt.io resources with Push/Pull mode constants and update class-generator schema for the new CRDs.
More details:
https://github.com/kubevirt/enhancements/blob/main/veps/sig-storage/incremental-backup.md
What this PR does / why we need it:
Adds the VirtualMachineBackup and VirtualMachineBackupTracker Custom Resource Definitions (CRDs) required to support the Change Block Tracking (CBT) feature for incremental backups.
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:
Summary by CodeRabbit