build: Bump Verify.XunitV3 to 31.22.0 and force LF on snapshot files#68
Merged
Merged
Conversation
--- updated-dependencies: - dependency-name: Verify.XunitV3 dependency-version: 31.22.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Verify 31.21+ rejects verified snapshot files that contain a carriage return instead of normalizing them. Without a .gitattributes rule the Windows CI runner checks the *.verified.* files out as CRLF (core.autocrlf), so every GenDoc snapshot test fails on windows-latest after the Verify.XunitV3 31.22.0 bump. Add a targeted .gitattributes forcing eol=lf on *.verified.* and *.received.* so these files keep LF on every platform. The blobs are already stored as LF, so no content renormalization is needed. Scope is kept narrow to respect the repository's deliberate hands-off stance on line endings / charset elsewhere. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AbXi2ZEaUFeFWodNxdY6Zk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carries the Dependabot bump of
Verify.XunitV331.20.0 → 31.22.0 plus the compatibility fix it needs, so the update can land green. Supersedes the plain Dependabot PR #67, which fails onwindows-latest.Verify 31.21+ rejects verified snapshot files that contain a carriage return (previously it normalized them). The repo has no
.gitattributes, so the Windows CI runner checks the*.verified.*files out as CRLF (core.autocrlf) and all 14GenDocsnapshot tests fail there — a latent cross-platform issue the bump merely exposed.Type of change
Changes
Verify.XunitV331.20.0 → 31.22.0 (from Dependabot)..gitattributesforcingeol=lfon*.verified.*and*.received.*, so those files stay LF on every platform (including Windows checkout). The blobs are already LF, so no content renormalization is needed. Scope is kept narrow to respect the repo's deliberate hands-off stance on line endings / charset elsewhere.Testing
dotnet build FirstClassErrors.sln— not re-run locally for the.gitattributeschange (it cannot affect the build).dotnet test FirstClassErrors.sln— not run locally.FirstClassErrors.Analyzers.UnitTests) — not run locally.Build & test (ubuntu-latest)on build: Bump Verify.XunitV3 from 31.20.0 to 31.22.0 #67; this PR's CI validates the fix onwindows-latest, where the snapshot tests were failing.Documentation
Related issues
Supersedes #67 (Dependabot will close it once
Verify.XunitV3is updated onmain).Generated by Claude Code