Manually instrument traces in pixl_cli, orthanc_raw, and orthanc_anon#644
Open
p-j-smith wants to merge 10 commits into
Open
Manually instrument traces in pixl_cli, orthanc_raw, and orthanc_anon#644p-j-smith wants to merge 10 commits into
pixl_cli, orthanc_raw, and orthanc_anon#644p-j-smith wants to merge 10 commits into
Conversation
Add a function to get set the relevent otel env vars before calling configure_logging and configure_tracing
This way the span belongs to the CLI rather than to the queue
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
+ Coverage 87.79% 87.83% +0.04%
==========================================
Files 78 79 +1
Lines 3735 3772 +37
==========================================
+ Hits 3279 3313 +34
- Misses 456 459 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefpiatek
approved these changes
Jun 24, 2026
| from opentelemetry.sdk.trace import TracerProvider | ||
| from opentelemetry.sdk.trace.export import BatchSpanProcessor | ||
|
|
||
| __all__ = ["configure_tracing"] |
Contributor
There was a problem hiding this comment.
Oh interesting, what are we aiming to exclude exporting here?
| @pytest.fixture | ||
| def otel_logger( | ||
| monkeypatch: pytest.MonkeyPatch, | ||
| log_exporter: InMemoryLogRecordExporter, |
|
|
||
| x-otel-common: &otel-common | ||
| OTEL_EXPORTER_OTLP_ENDPOINT: ${OTEL_EXPORTER_OTLP_ENDPOINT:-} | ||
| OTEL_EXPORTER_OTLP_HEADERS: ${OTEL_EXPORTER_OTLP_HEADERS:-} |
Contributor
There was a problem hiding this comment.
Oh do we never use this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #639 Instrument the cli, Orthanc Raw, and Orthanc Anon so we can follow a DICOM study end-to-end
pixl_core.tracing.configure_tracingto set up a tracing provider_configure_telemetry_env_vars. Then configure tracing and instrument pikarecord_dicom_headers, not for the actual C-MOVEType of change
Please delete options accordingly to the description.
Suggested Checklist
mainbranch.squash and mergeAll logs selected for a given
trace_id(the trace corresponds to processing one of the DICOM studies in the integration tests):logs.mov
All spans for the same
trace_idtrace.mov