Add data-table built on @tanstack/angular-table#63
Merged
Conversation
sjoerdbeentjes
changed the title
sjoerdbeentjes
force-pushed
the
feat/angular-data-table
branch
from
027aad5 to
b0a1066
Compare
loofpc
reviewed
Jul 1, 2026
Mirror the React data-table for @surfnet/angular. Ships a headless injectDataTable helper plus presentational pieces (HlmDataTableContent, HlmDataTablePagination, hlmDataTableToolbar) for sorting, filtering, pagination, column visibility and row selection on top of the existing helm table. Uses @tanstack/angular-table v8 (stable, version-matched to React's @tanstack/react-table) and reuses the existing dataTableContract.
… in data-table story
ng-packagr doesn't resolve tsconfig path aliases when bundling, so vendored helm-to-helm imports through @spartan-ng/helm/* were leaking into dist as unresolved external imports (that package doesn't exist on npm), sometimes alongside a correctly inlined duplicate of the same symbol. Add a codemod (fix-helm-imports, run via jiti) to rewrite them to relative paths after every `ng g` run.
Record the @spartan-ng/helm alias/ng-packagr incompatibility and the decision to rewrite cross-component imports to relative paths, per the existing PoC decision log convention (brought over from main, which this branch predates).
sjoerdbeentjes
force-pushed
the
feat/angular-data-table
branch
from
0d19d2c to
22975d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
data-tableto@surfnet/angular, mirroring the React one. Built on@tanstack/angular-tableon top of the existing helmtable, with sorting, filtering, pagination, column visibility and row selection.What's included:
injectDataTable()— headless helper (based on React'suseDataTable)HlmDataTableContent,HlmDataTablePagination,hlmDataTableToolbarDefault/Empty/CustomToolbarstoriesNote: uses
@tanstack/angular-tablev8 (stable, matches React's table version).Verified: build, type-check and format pass; sorting, filtering and row selection work in Storybook.