[Performance] Memoize isWsl#7794
Conversation
The `isWsl` function in `packages/cli-kit/src/public/node/system.ts` performs a dynamic import of the `is-wsl` package every time it's called. While Node.js caches module imports, memoizing the result at the application level avoids the overhead of repeated module resolution lookups and promise creation. This PR memoizes the `isWsl` function by caching the promise of the dynamic import in a module-level variable. It also adds and exports an internal `_resetIsWsl` function to ensure test isolation. Unit tests have been updated and expanded to verify the memoization behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/system.d.ts@@ -111,6 +111,10 @@ export declare function isCI(): boolean;
* @returns True if the current environment is a WSL environment.
*/
export declare function isWsl(): Promise<boolean>;
+/**
+ * Resets the memoized WSL check.
+ */
+export declare function _resetIsWsl(): void;
/**
* Check if stdin has piped data available.
* This distinguishes between actual piped input (e.g., )
|
WHY are these changes introduced?
The
isWslfunction inpackages/cli-kit/src/public/node/system.tsperforms a dynamic import of theis-wslpackage every time it's called. While Node.js caches module imports, memoizing the result at the application level avoids the overhead of repeated module resolution lookups and promise creation.WHAT is this pull request doing?
This PR memoizes the
isWslfunction by caching the promise of the dynamic import in a module-level variable. It also adds and exports an internal_resetIsWslfunction to ensure test isolation. Unit tests have been updated and expanded to verify the memoization behavior.How to test your changes?
CI
Post-release steps
N/A
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 15665184249994513171 started by @gonzaloriestra