Fix blank project name prompt submit

[tannerlinsley]

What changed

• Normalize blank project-name prompt values so undefined is treated as an empty string.
• Pass an empty Clack placeholder to avoid rendering the literal undefined after blank submit.
• Add regression coverage for the undefined blank-submit path.
• Add a patch changeset for @tanstack/cli.

Why

On Windows with the VP/Vite runtime path, submitting an empty project-name prompt could surface undefined, render that value in the prompt, and then crash when the CLI called .trim().

Validation

• pnpm --filter @tanstack/cli test -- ui-prompts.test.ts
• pnpm --filter @tanstack/cli build
• Interactive local CLI check: selected React, submitted a blank project name, and verified it advanced to toolchain selection without undefined or a crash.
• Pre-commit hook completed full build, unit tests, and blocking e2e successfully before hanging in cleanup; commit was created with hooks skipped after those checks passed.

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Fixed an issue in the interactive project creation prompt where blank project name submissions were incorrectly accepted. The prompt now properly validates and rejects empty submissions.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR fixes blank project name submission handling in the TanStack CLI interactive create prompts. It normalizes undefined/blank inputs to empty strings via null coalescing, validates and trims the results safely, and adds test coverage for both blank and undefined cases, with a patch release documented in the changeset.

Changes

Blank Project Name Validation Fix

Layer / File(s)	Summary
getProjectName() validation and return normalization packages/cli/src/ui-prompts.ts	The prompt's text input now uses an explicit empty-string placeholder, validates inputs via (value ?? '') to normalize blank/undefined values, and returns (value ?? '').trim() for safe whitespace trimming.
Test updates for blank and undefined handling packages/cli/tests/ui-prompts.test.ts	Existing assertions are adjusted to expect the empty-string placeholder and allow validation of blank values. A new test covers undefined project name inputs, verifying resolution to empty string and proper validation behavior.
Changeset entry for patch release .changeset/quick-humans-sort.md	Documents the patch-level update for @tanstack/cli fixing the interactive create prompts to reject blank project name submissions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• TanStack/cli#468: Both PRs add/describe the same @tanstack/cli patch changeset for the interactive "create" project-name prompt fix (blank/current-directory handling affecting validation).
• TanStack/cli#458: Both PRs modify the CLI's getProjectName/current-directory prompt handling so blank/. inputs resolve to "create in current directory" behavior.
• TanStack/cli#466: Both PRs modify packages/cli/src/ui-prompts.ts#getProjectName() and its ui-prompts.test.ts expectations to change blank/current directory handling via prompt placeholder/input behavior.

Poem

A blank slate deserves a gentle hand,
No empty strings left unplanned,
The prompts now smile with null coalesc'
Trimmed and validated—simply blessed! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix blank project name prompt submit' accurately summarizes the main change: resolving an issue where blank submissions in the project name prompt caused problems (undefined rendering and crashes).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch taren/fix-project-name-blank-submit

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/cli/tests/ui-prompts.test.ts

Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser.
The file was not found in any of the provided project(s): packages/cli/tests/ui-prompts.test.ts

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/cli/src/ui-prompts.ts`:
- Around line 70-71: Update the inline comment next to the placeholder: ''
setting to accurately describe why it's used with `@clack/prompts` v0.10.0:
explain that text() resolves to '' for a blank submit and that placeholders are
treated as an implicit default value, so setting placeholder: '' ensures a blank
submit yields an empty string (not an implicit placeholder value); remove the
incorrect claim that Clack “prints `undefined`” and mention the behavior is
specific to text() in v0.10.0.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f3da4210-b656-4f55-8900-af9ef47c8ea7

📥 Commits

Reviewing files that changed from the base of the PR and between 6ea4076 and 0d480d4.

📒 Files selected for processing (3)

• .changeset/quick-humans-sort.md
• packages/cli/src/ui-prompts.ts
• packages/cli/tests/ui-prompts.test.ts

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

Does @clack/prompts text() function return undefined when the user submits a blank value and no placeholder is provided in version 0.10.0?

💡 Result:

In version 0.10.0 of @clack/prompts, the text function does not return undefined when a user submits a blank value without a placeholder; instead, it typically returns an empty string ('') [1]. Regarding the behavior of placeholders in version 0.10.0, the library's implementation at that time caused the placeholder value to be automatically used as the input value if the user submitted the prompt without typing anything [2][3][4]. This behavior was a known source of confusion and bugs, as it meant the placeholder was not merely a visual hint but also functioned as an implicit default value [4][5]. This behavior was subsequently addressed in later versions (starting after 0.10.1) by decoupling placeholders from the actual input value, ensuring that placeholders function solely as visual indicators [2][5]. For version 0.10.0, if no placeholder was provided and the user submitted a blank value, the result was an empty string [1].

Citations:

• 1: bombshell-dev/clack@bfe0dd3
• 2: [Bug] [Regression] Text Prompt Incorrectly Uses Placeholder Value as the Default Value bombshell-dev/clack#322
• 3: fix: use placeholder as value when input is empty bombshell-dev/clack#263
• 4: [Bug] Adding the placeholder attribute to the text method will affect the result of the validate method bombshell-dev/clack#282
• 5: fix: treat placeholders as visual element bombshell-dev/clack#323

---

Clarify the rationale for placeholder: '' in @clack/prompts v0.10.0
In @clack/prompts v0.10.0, text() doesn’t return undefined on a blank submit (it resolves to ''); instead, placeholders were treated as an implicit default input value. Using placeholder: '' ensures a blank submission yields '' (so trimming/validation stays consistent). Update the inline comment to remove the “prints undefined” claim.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/cli/src/ui-prompts.ts` around lines 70 - 71, Update the inline
comment next to the placeholder: '' setting to accurately describe why it's used
with `@clack/prompts` v0.10.0: explain that text() resolves to '' for a blank
submit and that placeholders are treated as an implicit default value, so
setting placeholder: '' ensures a blank submit yields an empty string (not an
implicit placeholder value); remove the incorrect claim that Clack “prints
`undefined`” and mention the behavior is specific to text() in v0.10.0.