Skip to content

Fix OPT_POST_GRT_WNS and disable for some PDKs#4343

Merged
maliberty merged 7 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-fix-wns-opt
Jul 9, 2026
Merged

Fix OPT_POST_GRT_WNS and disable for some PDKs#4343
maliberty merged 7 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-fix-wns-opt

Conversation

@jfgava

@jfgava jfgava commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

There is no need to run vt_swap and reroute for PDKs that don't benefit from it.
In this PR I disabled this optimization for Sky130HD/HS, GF180, Nangate45, IHP-SG13G2.

The reroute move does not account for capacitance, which is more relevant to timing closure on these PDKs.
It is possible to reroute a net to a lower-resistance path, but at significantly higher capacitance, which degrades timing.

Currently, we are missing an estimate_parasitics call before running the additional optimizations.
And as we are not changing placement with Reroute and VtSwap, there is no need for a legalization + incremental GRT post-repair_setup.

This prevents issues with another PR with Reroute move enhancements

designs/sky130hd/microwatt/rules-base.json updates:

Metric Old New Type
globalroute__antenna_diodes_count 1747 1692 Tighten
detailedroute__antenna__violating__nets 0 1 Failing
detailedroute__antenna_diodes_count 1297 1295 Tighten
finish__timing__setup__tns -312.0 -307.0 Tighten
finish__timing__hold__tns -5.02 -4.65 Tighten

jfgava added 4 commits July 8, 2026 16:08
…ng estimate_parasitics

Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava jfgava self-assigned this Jul 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the global routing helper script to execute incremental global routing, detailed placement, and parasitics estimation unconditionally, while restricting the post-repair timing optimization to run conditionally based on the OPT_POST_GRT_WNS environment variable. Additionally, it defines OPT_POST_GRT_WNS as 0 across multiple platform configuration files. The reviewer feedback suggests using the conditional assignment operator ?= instead of = for OPT_POST_GRT_WNS in the platform configuration files to allow design-specific overrides.

Comment thread flow/platforms/gf180/config.mk Outdated
Comment thread flow/platforms/ihp-sg13g2/config.mk Outdated
Comment thread flow/platforms/nangate45/config.mk Outdated
Comment thread flow/platforms/sky130hd/config.mk Outdated
Comment thread flow/platforms/sky130hs/config.mk Outdated
Comment thread flow/scripts/global_route.tcl
jfgava added 3 commits July 8, 2026 22:22
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava jfgava requested a review from maliberty July 9, 2026 18:26
@maliberty maliberty merged commit bde10c7 into The-OpenROAD-Project:master Jul 9, 2026
8 of 11 checks passed
@maliberty maliberty deleted the secure-fix-wns-opt branch July 9, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants