Skip to content

update metrics for bp_single and bp_quad#4345

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update_gf12_metrics
Jul 10, 2026
Merged

update metrics for bp_single and bp_quad#4345
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update_gf12_metrics

Conversation

@eder-matheus

Copy link
Copy Markdown
Member

designs/gf12/bp_quad/rules-base.json updates:

Metric Old New Type
cts__timing__setup__tns -247000.0 -638000.0 Failing
globalroute__timing__setup__tns -702.0 -8020.0 Failing
detailedroute__route__drc_errors 1 0 Tighten
finish__timing__setup__ws -219.0 -208.0 Tighten
finish__timing__setup__tns -1620.0 -1420.0 Tighten

designs/gf12/bp_single/rules-base.json updates:

Metric Old New Type
cts__timing__setup__tns -517000.0 -474000.0 Tighten
cts__timing__hold__tns -4250.0 -4700.0 Failing
globalroute__timing__setup__ws -615.0 -556.0 Tighten
globalroute__timing__setup__tns -106000.0 -79400.0 Tighten

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
@eder-matheus eder-matheus self-assigned this Jul 10, 2026
@eder-matheus eder-matheus requested a review from maliberty July 10, 2026 15:34

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the regression baseline metrics in rules-base.json for the bp_quad and bp_single designs. While some metrics show improvements, the reviewer highlighted significant timing degradations in the bp_quad design for both cts__timing__setup__tns and globalroute__timing__setup__tns. The reviewer requested clarification or a tracking issue to address these regressions before merging.

},
"cts__timing__setup__tns": {
"value": -247000.0,
"value": -638000.0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The cts__timing__setup__tns metric shows a significant degradation (from -247000.0 to -638000.0). Please provide the explicit agreement or tracking issue to address this timing degradation later, or clarify if this is caused by parasitics estimation bug fixes.

References
  1. It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.

},
"globalroute__timing__setup__tns": {
"value": -702.0,
"value": -8020.0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The globalroute__timing__setup__tns metric shows a significant degradation (from -702.0 to -8020.0). Please provide the explicit agreement or tracking issue to address this timing degradation later, or clarify if this is caused by parasitics estimation bug fixes.

References
  1. It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.

@maliberty maliberty merged commit 45272af into The-OpenROAD-Project:master Jul 10, 2026
6 of 8 checks passed
@maliberty maliberty deleted the update_gf12_metrics branch July 10, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants