update metrics for bp_single and bp_quad#4345
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request updates the regression baseline metrics in rules-base.json for the bp_quad and bp_single designs. While some metrics show improvements, the reviewer highlighted significant timing degradations in the bp_quad design for both cts__timing__setup__tns and globalroute__timing__setup__tns. The reviewer requested clarification or a tracking issue to address these regressions before merging.
| }, | ||
| "cts__timing__setup__tns": { | ||
| "value": -247000.0, | ||
| "value": -638000.0, |
There was a problem hiding this comment.
The cts__timing__setup__tns metric shows a significant degradation (from -247000.0 to -638000.0). Please provide the explicit agreement or tracking issue to address this timing degradation later, or clarify if this is caused by parasitics estimation bug fixes.
References
- It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.
| }, | ||
| "globalroute__timing__setup__tns": { | ||
| "value": -702.0, | ||
| "value": -8020.0, |
There was a problem hiding this comment.
The globalroute__timing__setup__tns metric shows a significant degradation (from -702.0 to -8020.0). Please provide the explicit agreement or tracking issue to address this timing degradation later, or clarify if this is caused by parasitics estimation bug fixes.
References
- It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.
designs/gf12/bp_quad/rules-base.json updates:
designs/gf12/bp_single/rules-base.json updates: