bazel: enable layering check for syn tests#10709
Merged
maliberty merged 1 commit intoJun 22, 2026
Merged
Conversation
Signed-off-by: naveenvenk17 <naveenvenkat1711@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the src/syn/test/BUILD file to enable the layering_check feature at the package level, while removing the individual -layering_check feature exclusions from all cc_test targets. There are no review comments, so I have no feedback to provide.
maliberty
approved these changes
Jun 22, 2026
maliberty
enabled auto-merge
June 22, 2026 16:32
maliberty
merged commit Jun 22, 2026
5b269de
into
The-OpenROAD-Project:master
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #10478.
src/syn/test/BUILDhad per-testfeatures = ["-layering_check"]entries, but the tests include exportedsynheaders through their declared deps. Enable layering checks for the package and remove the stale per-target disables from the tensyncc_tests.Test plan:
git diff --checkbuildifier -mode=check -lint=off src/syn/test/BUILDbazelisk query //src/syn/test:all --noshow_progressI also attempted
bazelisk cquery //src/syn/test:ir_test --features=layering_check --noshow_progress; local analysis was blocked because this checkout is missing thesrc/stasubmodule package required by//src/syn/src/ir.