Skip to content

fix: use adjoint matrix for 3x3 inverse#14840

Open
abhi-zit77 wants to merge 1 commit into
TheAlgorithms:masterfrom
abhi-zit77:fix-14813-inverse-of-matrix
Open

fix: use adjoint matrix for 3x3 inverse#14840
abhi-zit77 wants to merge 1 commit into
TheAlgorithms:masterfrom
abhi-zit77:fix-14813-inverse-of-matrix

Conversation

@abhi-zit77

Copy link
Copy Markdown

Describe your change:

Fixes the 3x3 branch of inverse_of_matrix() so it uses the computed adjoint matrix when applying the inverse formula. Previously, the function computed adjoint_matrix but seeded inverse_matrix from cofactor_matrix, returning the transpose of the true inverse for non-symmetric 3x3 matrices.

Fixes #14813

How tested

  • .\.venv\Scripts\python.exe -m doctest -v matrix\inverse_of_matrix.py
  • .\.venv\Scripts\python.exe -m pytest --doctest-modules matrix\inverse_of_matrix.py -q
  • .\.venv\Scripts\ruff.exe check matrix\inverse_of_matrix.py
  • .\.venv\Scripts\python.exe -m mypy --ignore-missing-imports matrix\inverse_of_matrix.py
  • git diff --check
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

matrix/inverse_of_matrix: 3x3 inverse returns the transpose of the true inverse (adjoint computed but unused)

1 participant