Skip to content

ci: correctly replace parent version in downstream build workflow#2423

Merged
triceo merged 3 commits into
mainfrom
ci/downstream-jfrog-credentials
Jun 26, 2026
Merged

ci: correctly replace parent version in downstream build workflow#2423
triceo merged 3 commits into
mainfrom
ci/downstream-jfrog-credentials

Conversation

@rsynek

@rsynek rsynek commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Added JFrog credentials for downloading parent pom.xml to upgrade models' version to solver snapshot.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the downstream build reusable workflow to configure Maven authentication for a JFrog-hosted repository so downstream projects can resolve Timefold artifacts (notably the solver service parent) during builds.

Changes:

  • Adds actions/setup-java@v5 Maven server credential configuration (server-id, server-username, server-password) targeting the timefold repository ID.

Comment thread .github/workflows/downstream_build.yml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread .github/workflows/pull_request_secure_downstream.yml Outdated
Comment thread .github/workflows/pull_request_secure_downstream.yml Outdated
Comment thread .github/workflows/pull_request_secure_downstream.yml Outdated
Comment thread .github/workflows/downstream_build.yml Outdated
rsynek added 3 commits June 26, 2026 16:19
Added JFrog credentials for downloading parent pom.xml to upgrade models' version to solver snapshot.
@rsynek rsynek force-pushed the ci/downstream-jfrog-credentials branch from cbd2bcf to 4a951c1 Compare June 26, 2026 14:19
Copilot AI review requested due to automatic review settings June 26, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread .github/workflows/downstream_build.yml
Comment thread .github/workflows/downstream_build.yml
Comment thread .github/workflows/downstream_build.yml
@sonarqubecloud

Copy link
Copy Markdown

@triceo triceo changed the title ci: add JFrog credentials to downstream build workflow ci: correctly replace parent version in downstream build workflow Jun 26, 2026
@triceo triceo merged commit 84516cc into main Jun 26, 2026
26 of 29 checks passed
@triceo triceo deleted the ci/downstream-jfrog-credentials branch June 26, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants