Skip to content

refactor(plugin-network-capture-browser): change BodyCaptureRule import to "type"#1859

Open
daniel-graham-amplitude wants to merge 1 commit into
mainfrom
no-ticket-remove-body-capture-esm-import
Open

refactor(plugin-network-capture-browser): change BodyCaptureRule import to "type"#1859
daniel-graham-amplitude wants to merge 1 commit into
mainfrom
no-ticket-remove-body-capture-esm-import

Conversation

@daniel-graham-amplitude

@daniel-graham-amplitude daniel-graham-amplitude commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

Note

Low Risk
Single-line import change with no logic or runtime impact.

Overview
Updates the BodyCaptureRule import in track-network-event.ts from a regular import to import type, since it is only used for TypeScript annotations (e.g. isBodyCaptureRuleEmpty).

No runtime or API behavior changes—this is an import-style fix for clearer type-only usage and typical bundler/TS emit behavior.

Reviewed by Cursor Bugbot for commit 105655d. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown

size-limit report 📦

Path Size
packages/analytics-browser/lib/scripts/amplitude-min.js.gz 60.57 KB (0%)
packages/session-replay-browser/lib/scripts/session-replay-browser-min.js.gz 133.19 KB (0%)
packages/unified/lib/scripts/amplitude-min.umd.js.gz 213.16 KB (0%)
@amplitude/element-selector (gzipped esm) 2.67 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant