fix(acp): register compact and summarize commands for visibility#31644
Open
szzhoujiarui-sketch wants to merge 3 commits into
Open
fix(acp): register compact and summarize commands for visibility#31644szzhoujiarui-sketch wants to merge 3 commits into
szzhoujiarui-sketch wants to merge 3 commits into
Conversation
- Add progress tracking with stage-based updates - Display download percentage, size, and speed for curl method - Show progress messages for all installation methods - Backward compatible with optional progress callback - Fixes anomalyco#31623
Add /compact and /summarize to the default command registry so they appear in command autocomplete and /help. The commands maintain their special handling in ACP service (calling session.summarize API) while now being visible to users. Changes: - Add COMPACT and SUMMARIZE to Command.Default constants - Register both commands in Command service with descriptions - Update ACP service to exclude these commands from standard command path - Add unit tests verifying commands appear in available_commands_update - Add test for /summarize slash command behavior Closes anomalyco#31636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31636
Type of change
What does this PR do?
Fixes the missing
/compactand/summarizecommands from the command autocomplete and/helplist.Root cause: These commands were implemented with special handling in the ACP service but were never registered in the Command service, so they didn't appear in the
availableCommandslist sent to the UI.Changes:
COMPACTandSUMMARIZEtoCommand.Defaultconstantssession.summarizeAPI) while including them in the visible command listavailable_commands_update/summarizeslash command behaviorExample: Users will now see:
/compact- compress session history to preserve key information/summarize- generate a concise summary of the sessionHow did you verify your code works?
test/acp/service-session.test.tspassincludes compact and summarize in available commands- verifies commands appear in UIsummarize slash command calls summarize path- verifies/summarizebehaviorsession.summarizeAPI correctlyChecklist