refactor: Replace _handle_request elif chains with a handler registry #65827#68106
Draft
JH-A-Kim wants to merge 11 commits into
Draft
refactor: Replace _handle_request elif chains with a handler registry #65827#68106JH-A-Kim wants to merge 11 commits into
JH-A-Kim wants to merge 11 commits into
Conversation
JH-A-Kim
force-pushed
the
refactor-handle_request-with-handler-registry
branch
2 times, most recently
from
e220072 to
849d275
Compare
Add the registry for request_handlers.py so we can refactor _handle_request in handlers
…NotImplementedError with registry dispach
JH-A-Kim
force-pushed
the
refactor-handle_request-with-handler-registry
branch
from
8d75303 to
4de5af1
Compare
… tests client is now a required field in WatchedSubProcess so we now have to pass a mock to satisfy the constructor
handle_mask_secret does not use the client field but it requires the client:Client because it needs to satisfy the uniform handler contract stipulated by the registry dispatcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #65827
This pull request aims to refactor _handle_request elif chains with a handler registry.
WIP
Was generative AI tooling used to co-author this PR?
Generated-by: [Sonnet 4.6] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.