Fix backfill completion race during creation#68125
Open
GayathriSrividya wants to merge 1 commit into
Open
Conversation
GayathriSrividya
force-pushed
the
fix/64534-backfill-create-race
branch
from
7eec677 to
e8be38b
Compare
GayathriSrividya
force-pushed
the
fix/64534-backfill-create-race
branch
from
e8be38b to
c3d697a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #64534
Make backfill creation atomic so the scheduler cannot observe a partially initialized backfill and mark it complete before its DagRuns are created.
This moves the DagRun-info computation ahead of Backfill persistence, replaces the early commit with a flush so the whole create path stays in one transaction, and adds a regression test to verify failed no-run backfill creation does not leave an orphan Backfill row behind.