GH-17081: [C++] arrow::stl::TupleRangeFromTable docs incorrect#50095
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the C++ documentation example for arrow::stl::TupleRangeFromTable by adding the missing parameters (arrow::compute::CastOptions and arrow::compute::ExecContext) so the example matches the actual API signature in cpp/src/arrow/stl.h.
Changes:
- Update the narrative text to mention
CastOptionsandExecContextare needed for conversions. - Update the code snippet to construct
ExecContext/CastOptionsand pass them toTupleRangeFromTable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 901a6d5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The documentation example for TupleRangeFromTable was missing the cast_options and ctx parameters, so it didn't match the actual function signature
What changes are included in this PR?
Add them
Are these changes tested?
No
Are there any user-facing changes?
Better docs