GH-50113: [C++][Python] Fix count for sliced union arrays#50114
Merged
pitrou merged 1 commit intoJun 10, 2026
Conversation
|
|
1495b90 to
2d37d2b
Compare
Member
|
I've rebased from git main so as to incorporate #50108 |
Contributor
Author
|
Some tests failed, but they look unrelated to this PR. |
Contributor
Author
|
And thanks for the review. |
Member
Indeed they do! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fea7897. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Sliced union arrays could report incorrect results from
count.For sliced union arrays,
span.GetValues<int8_t>(1)andspan.GetValues<int32_t>(2)already return offset-adjusted pointers. The logical null count path then indexed those pointers withspan.offset + i, effectively applying the parent offset twice.The sparse union path also checked child nullness with
iinstead ofspan.offset + i.What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
count#50113