Enhance cloudstack_disk_offering resource and datasource#301
Open
bddvlpr wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the cloudstack_disk_offering Terraform resource to support additional CloudStack disk-offering parameters and completes the CRUD implementation, while also introducing a new cloudstack_disk_offering data source (plus docs and acceptance tests) so disk offerings can be discovered and referenced by other resources.
Changes:
- Expanded
cloudstack_disk_offeringresource schema (custom sizing, storage/provisioning type, tags, display flag) and implemented Read/Update/Delete + Importer. - Added
cloudstack_disk_offeringdata source with filter-based selection and acceptance tests. - Updated/added website documentation for the resource and data source.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/r/disk_offering.html.markdown | Documents the expanded disk offering resource arguments and attributes. |
| website/docs/d/disk_offering.html.markdown | Adds documentation for the new disk offering data source. |
| cloudstack/resource_cloudstack_disk_offering.go | Implements full disk offering resource CRUD/import and adds missing schema parameters. |
| cloudstack/resource_cloudstack_disk_offering_test.go | Adds acceptance tests for disk offering resource scenarios (basic/customized/update). |
| cloudstack/provider.go | Registers the new disk offering data source with the provider. |
| cloudstack/data_source_cloudstack_disk_offering.go | Implements the disk offering data source and filter logic. |
| cloudstack/data_source_cloudstack_disk_offering_test.go | Adds an acceptance test validating the disk offering data source against a created resource. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a bunch of missing parameters to the disk offering resource. Initialized the data source for it while I was at it.
Tested on simulator.