Fix misleading error message when trying to restore and attach volumes from backups

[bernardodemarco]

Description

This PR fixes/improves an error message that is thrown when it is attempted to restore and attach volumes from backups to a target VM that is attached to a backup offering. The message mentions that the target VM has backups, but that is not necessarily true. If they are simply attached to a backup offering, the error message will already be emitted.

I have run into this situation when testing KBOSS (see #12758 (comment)).

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (4244c2c) to head (c3db401).

Files with missing lines	Patch %	Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #13450   +/-   ##
=========================================
  Coverage     16.25%   16.26%           
- Complexity    13432    13434    +2     
=========================================
  Files          5667     5667           
  Lines        500670   500670           
  Branches      60801    60801           
=========================================
+ Hits          81397    81423   +26     
+ Misses       410165   410140   -25     
+ Partials       9108     9107    -1     

Flag	Coverage Δ
uitests	4.14% <ø> (ø)
unittests	17.11% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[winterhazel]

@blueorangutan package

[blueorangutan]

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 18315

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18326

[DaanHoogland]

/me hesistating, but as exception messages may be interpreted in integration tests, …
@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-16384)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 48296 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13450-t16384-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File