Fix/13612 template cleanup on domain delete

[Chinmay048]

Description

This PR fixes an issue where templates belonging to child accounts within a domain were not properly tracked during automated account and domain cleanup, causing domain deletion to fail due to orphaned storage resources.

Functional Changes:

• Updated AccountManagerImpl.cleanupAccount to explicitly check the boolean return value of _tmpltMgr.delete(...).
• Prevented the allTemplatesDeleted tracking flag from being overwritten on subsequent loop iterations if an earlier template deletion fails.
• Ensured that any failed template deletion correctly sets accountCleanupNeeded = true, preventing premature domain teardowns when child resources remain active in secondary storage.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• I have read the CONTRIBUTING document.
• My changes generate no new warnings or checkstyle errors.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

• In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
• Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
• Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
• Be sure to read the CloudStack Coding Conventions.
  Apache CloudStack is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
  Slack: https://apachecloudstack.slack.com/

[Copilot]

Pull request overview

This PR addresses a cleanup edge case during account/domain teardown where template deletions that return false could be effectively “masked” by later successful deletions, leading to premature domain deletion attempts while template artifacts still remained in secondary storage.

Changes:

• Update template cleanup loop in AccountManagerImpl.cleanupAccount to treat any false return from _tmpltMgr.delete(...) as a persistent failure signal (without being overwritten by later iterations).
• Improve logging for the false return case and ensure exceptions also force allTemplatesDeleted = false.
• Ensure accountCleanupNeeded is set when any template deletion fails, preventing premature teardown.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.