branch-4.0: [fix](auto partition) keep load row metrics monotonic for auto partition #64109#64135
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](auto partition) keep load row metrics monotonic for auto partition #64109#64135github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…ion (#64109) ### What problem does this PR solve? When loading into an auto partition table, BE may temporarily batch rows whose target partitions do not exist yet. The previous logic first incremented `doris_be_load_rows` when receiving the input block, then decremented it when those rows were moved into the auto-partition batching block, and finally incremented it again when the batched rows were replayed after partition creation. Because `doris_be_load_rows` is exposed as a counter, the negative adjustment made the metric non-monotonic and could show row count drops during auto partition loads. This PR keeps the existing `RuntimeState` row compensation logic unchanged, but stops applying negative deltas to the global BE load row/byte metrics. It also skips global metric increments when replaying the internal batched block, so each source row is counted once.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64109