HBASE-30159 Make hash algorithm configurable for HashTable and SyncTable#8321
Open
jinhyukify wants to merge 1 commit into
Open
HBASE-30159 Make hash algorithm configurable for HashTable and SyncTable#8321jinhyukify wants to merge 1 commit into
jinhyukify wants to merge 1 commit into
Conversation
jinhyukify
commented
Jun 6, 2026
Comment on lines
+229
to
+230
| ImmutableMap<Integer, ImmutableBytesWritable> expectedHashes = | ||
| ImmutableMap.<Integer, ImmutableBytesWritable> builder() |
Contributor
Author
There was a problem hiding this comment.
Generated SHA-256 hashes using this script.
https://gist.github.com/jinhyukify/705b9b6b81d06973556d5645353efcbb
| for (int i = 0; i < args.length - NUM_ARGS; i++) { | ||
| String cmd = args[i]; | ||
| if (cmd.equals("-h") || cmd.startsWith("--h")) { | ||
| if (cmd.equals("-h") || cmd.equals("--help")) { |
Contributor
Author
There was a problem hiding this comment.
Without this change, we cannot use options that start with --h including --hashAlgorithm
| endTime = Long.parseLong(endTimeString); | ||
| } | ||
|
|
||
| hashAlgorithm = p.getProperty("hashAlgorithm", DEFAULT_HASH_ALGORITHM); |
Contributor
Author
There was a problem hiding this comment.
For old HashTable files, we fall back to the original MD5 algorithm.
junegunn
reviewed
Jun 7, 2026
| empty.writePartitionFile(fs.getConf(), new Path(testDir, HashTable.PARTITIONS_FILE_NAME)); | ||
|
|
||
| HashTable.TableHash tableHash = HashTable.TableHash.read(fs.getConf(), testDir); | ||
| assertEquals("MD5", tableHash.hashAlgorithm, |
Member
There was a problem hiding this comment.
Can we refer to DEFAULT_HASH_ALGORITHM here?
Comment on lines
+655
to
+656
| System.err.println(" hashAlgorithm MessageDigest algorithm to use for batch hashes"); | ||
| System.err.println(" (defaults to " + DEFAULT_HASH_ALGORITHM + ")"); |
Member
There was a problem hiding this comment.
Would it help to show the available candidates?
jshell> System.out.println(java.security.Security.getAlgorithms("MessageDigest"));
[SHA3-512, SHA-1, SHA-384, SHA3-384, SHA-224, SHA-512/256, SHA-256, MD2, SHA-512/224, SHA3-256, SHA-512, SHA3-224, MD5]
Too many?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-30159