fix(go): complete TCP client teardown when conn.Close fails#3670
Merged
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3670 +/- ##
============================================
- Coverage 73.59% 73.50% -0.09%
Complexity 937 937
============================================
Files 1297 1291 -6
Lines 143769 141555 -2214
Branches 119330 117114 -2216
============================================
- Hits 105811 104056 -1755
+ Misses 34591 34276 -315
+ Partials 3367 3223 -144
🚀 New features to boost your workflow:
|
hubcio
approved these changes
Jul 14, 2026
numinnex
approved these changes
Jul 14, 2026
spetz
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Relates to #3652 (comment)
Relates to #3621 (comment)
Rationale
Golang SDK TCP client return the error directly when
c.conn.Close()return an error. This stop it from finishing the disconnect and shutdown process.What changed?
c.conntonilLocal Execution
AI Usage