[python] Fix blob column updates with rolling files#8156
Merged
Conversation
XiaoHongbo-Hope
changed the title
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Before this PR, all rolled blob update files were assigned the same
first_row_id. As a result, valid BLOB column updates could fail during commit withRow ID existence conflict, because the dedicated blob files no longer described the correct row-id ranges.This PR assigns proper contiguous row-id ranges to rolled blob files and relaxes row-id existence checking for dedicated BLOB files to validate range coverage by normal data files.
Test plan
test_update_blob_column_with_rolling_filestest_update_partial_blob_column_with_rolling_filesTestCheckRowIdExistence