RANGER-5657: Limit getAllModuleNames() to sys-admin sessions in SessionMgr#1036
Open
ramackri wants to merge 1 commit into
Open
RANGER-5657: Limit getAllModuleNames() to sys-admin sessions in SessionMgr#1036ramackri wants to merge 1 commit into
ramackri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up fix for RANGER-5627 / #1000.
RANGER-5627 added configuration-based super users (
ranger.admin.super.users/ranger.admin.super.groups) and changedSessionMgr.resetUserModulePermission()to grant all UI modules when
isUserAdmin() || isKeyAdmin().That
isKeyAdmin()branch is unintended for DBROLE_KEY_ADMINusers:modules via
findAccessibleModulesByUserId().getAllModuleNames(), includingSecurity Zone, even when not listed in super-user config and without an
explicit DB module grant.
Security Zone read APIs authorize with
hasModuleAccess("Security Zone"), whichchecks the session module set populated by
resetUserModulePermission(). DBkey-admin therefore incorrectly gets HTTP 200 on zone GET APIs instead of 400.
This patch: use
getAllModuleNames()only whenuserSession.isUserAdmin().Config super-users are not affected — they already get full admin through
superUser→isUserAdmin()inUserSessionBase. DB key-admin retainsDB-scoped modules (Key Manager and any explicitly granted modules only).
JIRA: https://issues.apache.org/jira/browse/RANGER-5657
How was this patch tested?
TestSessionMgr— existing super-user / session tests (19 tests passed)TestRangerSuperUserConfig— config super-user behavior unchanged (20tests passed )
Manual verification (recommended):
super.users/super.groups)GET /service/xusers/users/profile— should not list Security ZoneGET /service/public/v2/api/zones— expect 400 (not authorized)ranger.admin.super.usersfor a test user, re-login