Skip to content

[Tests] Guard TIRX CUDA tests by compute capability#19699

Draft
spectrometerHBH wants to merge 9 commits into
mainfrom
fix-tirx-cuda-sm-guards
Draft

[Tests] Guard TIRX CUDA tests by compute capability#19699
spectrometerHBH wants to merge 9 commits into
mainfrom
fix-tirx-cuda-sm-guards

Conversation

@spectrometerHBH

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request decorates various CUDA-related tests with @tvm.testing.requires_cuda_compute_version to ensure they only run on compatible hardware (SM 90 or SM 100). A review comment correctly identifies that test_tma_cache_policy_operand_codegen is decorated with version 9, but actually requires version 10 because it uses a Blackwell-specific (SM 100) intrinsic.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

assert "((unsigned long long)(&(A_map)))" in src


@tvm.testing.requires_cuda_compute_version(9)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The test test_tma_cache_policy_operand_codegen uses T.cuda.sm100_tma_2sm_mbarrier_addr (on line 349), which is a Blackwell (SM 100) specific intrinsic. Guarding it with compute version 9 (Hopper) will cause compilation or runtime failures on Hopper GPUs. It should be guarded by compute version 10 instead.

Suggested change
@tvm.testing.requires_cuda_compute_version(9)
@tvm.testing.requires_cuda_compute_version(10)

tlopex added a commit to tlopex/tvm that referenced this pull request Jun 10, 2026
PR apache#19699 (draft, being split by topic) carried a few optional
dependency guards alongside its CUDA compute-capability work. Move
them here where the optional-dependency gating lives:

- support/test_popen_pool.py: skip the module without cloudpickle
  (converted from a pytestmark skipif to the module-level
  pytest.importorskip used throughout this PR; ruff's E402 exemption
  covers importorskip but not pytestmark assignments)
- s_tir/meta_schedule/test_meta_schedule_builder.py: skip
  test_meta_schedule_missing_build_func without cloudpickle
- s_tir/meta_schedule/test_meta_schedule_cost_model.py: requires_xgboost
  marker on the five XGBModel tests
- codegen/test_target_codegen_blob.py: skip test_cuda_multi_lib without
  cloudpickle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant