[Runtime][Tests] Drop int4 from random_fill test, fix dtype error message#19748
Merged
Conversation
…sage apache#19714 intentionally removed packed sub-byte (bits 1/4) support from RandomEngine after the int4 fill path was found to write past the allocated storage, but left "int4" in test_random_fill's dtype list, so the test now fails with InternalError on every run. Remove it from the list to match the supported set. Also cast dtype.code / dtype.bits to int in the unsupported-dtype error messages: both fields are uint8_t and were streamed as (invisible) characters, e.g. "Doesn't support dtype code dtype bits".
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates mt_random_engine.cc to cast dtype.code and dtype.bits to int when formatting internal error messages. It also updates test_random.py to remove the unsupported int4 data type from the test list, adding a comment to clarify that packed sub-byte data types are intentionally unsupported. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tqchen
approved these changes
Jun 12, 2026
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
…sage (apache#19748) apache#19714 intentionally removed packed sub-byte (bits 1/4) support from RandomEngine after the int4 fill path was found to write past the allocated storage, but left "int4" in test_random_fill's dtype list, so the test now fails with InternalError on every run. Remove it from the list to match the supported set. Also cast dtype.code / dtype.bits to int in the unsupported-dtype error messages: both fields are uint8_t and were streamed as (invisible) characters, e.g. "Doesn't support dtype code dtype bits". (cherry picked from commit 59f8283)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
…sage (apache#19748) apache#19714 intentionally removed packed sub-byte (bits 1/4) support from RandomEngine after the int4 fill path was found to write past the allocated storage, but left "int4" in test_random_fill's dtype list, so the test now fails with InternalError on every run. Remove it from the list to match the supported set. Also cast dtype.code / dtype.bits to int in the unsupported-dtype error messages: both fields are uint8_t and were streamed as (invisible) characters, e.g. "Doesn't support dtype code dtype bits". (cherry picked from commit 59f8283)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19714 intentionally removed packed sub-byte (bits 1/4) support from RandomEngine after the int4 fill path was found to write past the allocated storage, but left "int4" in test_random_fill's dtype list, so the test now fails with InternalError on every run. Remove it from the list to match the supported set.
Also cast dtype.code / dtype.bits to int in the unsupported-dtype error messages: both fields are uint8_t and were streamed as (invisible) characters, e.g. "Doesn't support dtype code dtype bits".