ZOOKEEPER-5039: Raise to min JDK 17, also build, test with JDK25 by PDavid · Pull Request #2376 · apache/zookeeper

PDavid · 2026-04-23T12:08:05Z

Replaced maven.compiler.source + maven.compiler.target with a single maven.compiler.release=17
Removed maven.compiler.release property from m2e profile (it now inherits from main properties).
Removed jdk-release-flag Maven profile as it is not required anymore (maven.compiler.release=17 makes sure our build is compatible with Java 17).
Upgrade Mockito to 5.23.0 for JDK25: As of Mockito 5.x, the mockito-inline mock-maker became the default, so mockito-inline as a separate artifact is no longer needed.
Switch GH: Action workflows and Jenkins builds to JDK 17 and 25
Upgrade spotbugs to support Java 25
- Upgraded spotbugs-maven-plugin to 4.9.3.0 and annotations to 4.9.3.
- Overrode ASM to 9.9.1 in the plugin dependencies to support JDK 25 (class file version 69).
- Added newly found bug patterns to excludeFindBugsFilter.xml - these are all pre-existing issues in the codebase that the newer SpotBugs detects but the old version couldn't.
Upgrade burningwave mockdns to 0.27.2 to support JDK25
Fix PrometheusMetricsProviderConfigTest: Exception message differs now a bit.
Upgrade JDK version in dev Dockerfile

PDavid · 2026-04-23T12:59:37Z

OK, Mockito 5 requires Java 11 or higher. It will not work with Java 8.
Mockito 4 supported Java 8 but that does not support Java 25.

Do we have to support Java 8 on ZooKeeper master branch?

kgeisz

LGTM

anmolnar · 2026-04-29T19:22:36Z

I think we can drop Java 8 support on the master branch. Please follow the discussion on the dev@ list.

PDavid · 2026-05-07T14:32:37Z

It seems only changing the Jenkins file did not worked out:

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
WorkflowScript: 33: Tool type "jdk" does not have an install of "jdk_1.17_latest" configured - did you mean "jdk_1.8_latest"? @ line 33, column 13.
           jdk "jdk_1.17_latest"
               ^

https://ci-hadoop.apache.org/job/zookeeper-precommit-github-pr/job/PR-2376/5/console

Wrote to ASF Slack builds channel if thy can install / configure JDK 17 / JDK 25 for us.

anmolnar · 2026-05-07T18:58:48Z

It seems only changing the Jenkins file did not worked out:
org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
WorkflowScript: 33: Tool type "jdk" does not have an install of "jdk_1.17_latest" configured - did you mean "jdk_1.8_latest"? @ line 33, column 13.
           jdk "jdk_1.17_latest"
               ^
https://ci-hadoop.apache.org/job/zookeeper-precommit-github-pr/job/PR-2376/5/console

Wrote to ASF Slack builds channel if thy can install / configure JDK 17 / JDK 25 for us.

Might be (just guessing) jdk_17_latest and jdk_25_latest.

PDavid · 2026-05-08T11:01:21Z

SnapshotAndRestoreCommandTest.testSnapshotAndRestoreCommand_streaming failed in the GH: Action build. It succeeds for me locally so I guess it is just a flake here.

anmolnar

Lgtm. Please update and test Java version in dev/docker/Dockerfile as well.
Thanks!

PDavid · 2026-05-08T15:18:40Z

 #

-FROM maven:3.8.4-jdk-11
+FROM maven:3.9.6-eclipse-temurin-17


Since the old jdk and openjdk tags are deprecated, we should use the newer vendor-specific tags. Use Eclipse Temurin since we already use it in our GH: Actions workflows.

Also update Maven to 3.9.6 - it includes several improvements.

anmolnar

lgtm.

@eolivelli @ctubbsii PTAL

phunt · 2026-05-19T21:47:30Z

-1 - the documentation needs to be updated. Things like https://zookeeper.apache.org/doc/current/zookeeperAdmin.html - but please review all the docs to ensure covered.

Also the release notes (generated from JIRA) need to include this change, see : https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=135860428#HowToReleaseusingmavenreleaseplugin-Createreleasenotesonreleasebranch

phunt · 2026-05-19T22:25:41Z

fwiw claude(sonnet) says:

Documentation Files

  zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md — The main change. Update the Required Software section (~line 128) to set JDK 17 as the minimum instead of JDK
   8. Also review the TLS cipher suites section (~lines 1742/1899) which discusses Java 8 vs Java 9+ behavior — some of that context may no longer be relevant.

  README.md — Remove the caveat at ~line 42 about needing JDK 8 update u211 or later when compiling with Java 1.8.

  zookeeper-docs/src/main/resources/markdown/zookeeperStarted.md — No version text directly, but it links to zookeeperAdmin.md for requirements, so verify that reference
  still makes sense after the above change.

Build and CI files (not prose docs, but need to match):

  pom.xml — Update maven.compiler.source, maven.compiler.target, and maven.compiler.release from 1.8/8 to 17.

  .github/workflows/ci.yaml — Remove or replace the full-build-jdk8 matrix profile; make JDK 17 the primary.
  .github/workflows/e2e.yaml — Update jdk: [8, 11] to include 17 instead of 8.

The single most impactful documentation edit is zookeeperAdmin.md line ~128 — that's the canonical "required software" statement users and operators reference. The pom.xml
and CI workflow changes are mechanical but required to make the claim true.

PDavid · 2026-05-21T14:26:25Z

+    <Bug pattern="EI_EXPOSE_REP"/>
+    <Bug pattern="EI_EXPOSE_REP2"/>
+    <Bug pattern="CT_CONSTRUCTOR_THROW"/>
+    <Bug pattern="AT_STALE_THREAD_WRITE_OF_PRIMITIVE"/>
+    <Bug pattern="AT_NONATOMIC_64BIT_PRIMITIVE"/>
+    <Bug pattern="AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE"/>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Bug pattern="DCN_NULLPOINTER_EXCEPTION"/>
+    <Bug pattern="US_USELESS_SUPPRESSION_ON_METHOD"/>
+    <Bug pattern="US_USELESS_SUPPRESSION_ON_CLASS"/>
+    <Bug pattern="US_USELESS_SUPPRESSION_ON_FIELD"/>
+    <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
+    <Bug pattern="SS_SHOULD_BE_STATIC"/>
+    <Bug pattern="NP_UNWRITTEN_FIELD"/>
+    <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/>
+    <Bug pattern="MS_EXPOSE_REP"/>


Actually this suppression list are very broad. They are including real concurrency bugs (AT_STALE_THREAD_WRITE_OF_PRIMITIVE, AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE) and design issues (CT_CONSTRUCTOR_THROW, EI_EXPOSE_REP). Should we create a follow-up Jira to triage
and fix these incrementally?

Or should we suppress these by class so that these are not suppressed everywhere? We have 198 class/pattern combinations across these 16 patterns.

tamaashu · 2026-05-28T11:58:42Z


-ZooKeeper runs in Java, release 1.8 or greater
-(JDK 8 LTS, JDK 11 LTS, JDK 12 - Java 9 and 10 are not supported).
+ZooKeeper runs in Java, release 17 or greater


Should we define which ZooKeeper versions drop JDK8/11 support?

Thanks, good question. 👍

I guess the current master (3.10.x) drops the JDK8/11 support for sure.

@anmolnar wrote this on the dev list:

“… we could make a leap and make JDK 17 the minimum runtime and compile versions for the master branch.

Once the change is merged to master, we'll backport it to branch-3.9 as follows:

minimum JDK for building: 17

minimum JRE for running: 8 (no change) “

See: https://lists.apache.org/thread/xrd4ct4lv6hqd7mb2dqtx8v1nkzy7kjq

So I guess only 3.10.x drops JDK8/11 support then. 🤔

Do you all think I get it right?

That's correct. Java 17 supposed to be the minimum required runtime and compile version for 3.10.x (or whatever version is going to be cut from master).

@anmolnar what's the criteria for a major version? Is dropping support for older JDKs something that users might expect to be in a 4.x release? (It doesn't affect me as all my infra is ready for this change already, I'm mostly curious)

I remember when JDK7 got dropped, it was also a minor version.

I suggest rather discussing everything related to this change on the mailing list. It's probably going to be a 3.10.0 cut soon once this change is landed.

anmolnar

-1

I cannot execute gpg command inside the docker container.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-gpg-plugin:1.6:sign (sign-release-artifacts) on project parent: Unable to execute gpg command: Error while executing process. Cannot run program "gpg": error=2, No such file or directory -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
andor@317a015b04a9:/Users/andor/work/zkrelease/zookeeper$ gpg
bash: gpg: command not found

anmolnar · 2026-06-15T16:51:41Z

You need to add gnupg package to Dockerfile to be installed during provisioning.

Another problem is that Maven 3.9.x doesn't seem to be compatible with ZooKeeper. I got:

[ERROR] Unsupported policy: never
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
andor@1c56bb3be996:/Users/andor/work/zkrelease/zookeeper$ mvn -version
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /usr/share/maven
Java version: 17.0.11, vendor: Eclipse Adoptium, runtime: /opt/java/openjdk
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.8.0-50-generic", arch: "aarch64", family: "unix"

when trying to run mvn clean install -Pfull-build -Papache-release -DskipTests.

Please investigate.

anmolnar · 2026-06-15T17:00:58Z

FROM maven:3.8.8-eclipse-temurin-17 works fine for me.

PDavid · 2026-06-17T08:39:23Z

-    private volatile long totalGcExtraSleepTime = 0;
+    private final AtomicLong numGcWarnThresholdExceeded = new AtomicLong(0);
+    private final AtomicLong numGcInfoThresholdExceeded = new AtomicLong(0);
+    private final AtomicLong totalGcExtraSleepTime = new AtomicLong(0);


FYI: These were needed to fix the spotbugs issue:

[ERROR] High: Increment of volatile field org.apache.zookeeper.server.util.JvmPauseMonitor.numGcInfoThresholdExceeded in org.apache.zookeeper.server.util.JvmPauseMonitor$JVMMonitor.run() [org.apache.zookeeper.server.util.JvmPauseMonitor$JVMMonitor] At JvmPauseMonitor.java:[line 203] VO_VOLATILE_INCREMENT [ERROR] High: Increment of volatile field org.apache.zookeeper.server.util.JvmPauseMonitor.numGcWarnThresholdExceeded in org.apache.zookeeper.server.util.JvmPauseMonitor$JVMMonitor.run() [org.apache.zookeeper.server.util.JvmPauseMonitor$JVMMonitor] At JvmPauseMonitor.java:[line 200] VO_VOLATILE_INCREMENT

anmolnar

gpg is still missing from docker

As of Mockito 5.x, the mockito-inline mock-maker became the default, so mockito-inline as a separate artifact is no longer needed.

- Upgraded spotbugs-maven-plugin to 4.9.3.0 and annotations to 4.9.3. - Overrode ASM to 9.9.1 in the plugin dependencies to support JDK 25 (class file version 69). - Added newly found bug patterns to excludeFindBugsFilter.xml - these are all pre-existing issues in the codebase that the newer SpotBugs detects but the old version couldn't.

to fix test issue: Caused by: io.github.toolfactory.jvm.util.ObjectProvider$BuildingException: Exception occurred while retrieving the implementation of class io.github.toolfactory.jvm.function.catalog.ConstructorInvokeFunction (jvm architecture: x64, jvm version: 25, jvm vendor: Eclipse Adoptium)

Exception message differs now a bit.

Also update Maven to 3.9.6 - it includes several improvements. Since the old `jdk` and `openjdk` tags are deprecated, we should use the newer vendor-specific tags. Use Eclipse Temurin since we already use it in our GH: Actions workflows.

- Replaced maven.compiler.source=17 + maven.compiler.target=17 with a single maven.compiler.release=17 - Removed maven.compiler.release property from m2e profile (it now inherits from main properties).

Replace volatile long fields with AtomicLong to ensure atomic read-modify-write operations for increment and add. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

so that gpg command can be used by Maven.

to clarify what it is used for.

in the new website.

anmolnar

Add Maven enforcer rules to minimum Java and Maven versions just like in HBase.

Please see pull request: PDavid#1

PDavid · 2026-06-22T18:05:13Z

Add Maven enforcer rules to minimum Java and Maven versions just like in HBase.

Please see pull request: PDavid#1

Great idea, thanks, will do that.

…ersions Co-Authored-By: anmolnar

instead of Java 11.

PDavid · 2026-06-23T10:03:05Z

CnxManagerTest.testWorkerThreads test failed in the GH Action build:

[ERROR]   CnxManagerTest.testWorkerThreads:511 Tue Jun 23 09:09:46 UTC 2026 Incorrect number of Worker threads for sid=0 expected 4 found 2 ==> expected: <null> but was: <Tue Jun 23 09:09:46 UTC 2026 Incorrect number of Worker threads for sid=0 expected 4 found 2>

It is successful for me locally on this branch:

$ mvn test -Dtest=CnxManagerTest -pl zookeeper-server

...

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.zookeeper.server.quorum.CnxManagerTest
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.496 s - in org.apache.zookeeper.server.quorum.CnxManagerTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:32 min
[INFO] Finished at: 2026-06-23T12:02:04+02:00
[INFO] ------------------------------------------------------------------------
 ws1test3@FHTL1T3  ~/projects/upstream/zookeeper   ZOOKEEPER-5039-mockito-upgrade 

anmolnar

lgtm.

tamaashu

I believe [3.5.9, 3.6.3, 3.7.0, nightly] should be fixed, but it's not a blocker issue. Can be done separately.

phunt · 2026-06-23T21:26:09Z

lgtm - I built with jdk21 and it built fine. +1.

… Actions workflow

PDavid · 2026-06-24T09:16:39Z

org.apache.zookeeper.test.ReconfigTest.testRemoveAddTwo test failed in the Jenkins build but it is successful for me locally on this branch:

$ mvn test -Dtest=ReconfigTest -pl zookeeper-server

...

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.zookeeper.test.ReconfigTest
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 245.043 s - in org.apache.zookeeper.test.ReconfigTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  04:13 min
[INFO] Finished at: 2026-06-24T11:11:39+02:00
[INFO] ------------------------------------------------------------------------

anmolnar · 2026-06-24T19:24:43Z

Merged to master branch. Thanks @PDavid and the reviewers!

PDavid · 2026-06-25T06:54:42Z

Many thanks everyone for your reviews and help! 👍

kgeisz approved these changes Apr 24, 2026

View reviewed changes

PDavid force-pushed the ZOOKEEPER-5039-mockito-upgrade branch from a72fee0 to e413971 Compare May 7, 2026 09:17

PDavid changed the title ~~ZOOKEEPER-5039: Upgrade Mockito to 5.23.0 for JDK25~~ ZOOKEEPER-5039: Raise to min JDK 17, also build, test with JDK25 May 7, 2026

anmolnar requested changes May 8, 2026

View reviewed changes

PDavid commented May 8, 2026

View reviewed changes

PDavid requested a review from anmolnar May 11, 2026 06:59

anmolnar approved these changes May 11, 2026

View reviewed changes

PDavid commented May 21, 2026

View reviewed changes

PDavid force-pushed the ZOOKEEPER-5039-mockito-upgrade branch from 7671da3 to 36b3f83 Compare May 21, 2026 14:26

anmolnar mentioned this pull request May 21, 2026

ZOOKEEPER-5038 Decouple HTTP admin server into a separate module. #2395

Closed

tamaashu suggested changes May 28, 2026

View reviewed changes

anmolnar requested changes Jun 15, 2026

View reviewed changes

anmolnar mentioned this pull request Jun 16, 2026

ZOOKEEPER-5054: Netty client should allow every supported TLS ciphers #2404

Open

PDavid force-pushed the ZOOKEEPER-5039-mockito-upgrade branch from 52147af to 88564d2 Compare June 17, 2026 08:37

PDavid commented Jun 17, 2026

View reviewed changes

PDavid requested review from anmolnar, tamaashu and txangel June 17, 2026 10:22

anmolnar requested changes Jun 18, 2026

View reviewed changes

Comment thread dev/docker/Dockerfile

PDavid added 2 commits June 22, 2026 11:27

ZOOKEEPER-5039: Upgrade Mockito to 5.23.0 for JDK25

88cd989

As of Mockito 5.x, the mockito-inline mock-maker became the default, so mockito-inline as a separate artifact is no longer needed.

ZOOKEEPER-5039: Switch GH: Action workflows to JDK 17 and 25

077fbdd

PDavid and others added 14 commits June 22, 2026 11:27

ZOOKEEPER-5039: Switch Jenkins workflows to JDK 17 and 25

e0684de

ZOOKEEPER-5039: Upgrade spotbugs to support JDK 17

a07e58e

ZOOKEEPER-5039: Fix PrometheusMetricsProviderConfigTest

9a95d36

Exception message differs now a bit.

ZOOKEEPER-5039: Change Maven compiler source and target to 17

58762dd

ZOOKEEPER-5039: Align Maven compiler Java versions

891909c

- Replaced maven.compiler.source=17 + maven.compiler.target=17 with a single maven.compiler.release=17 - Removed maven.compiler.release property from m2e profile (it now inherits from main properties).

ZOOKEEPER-5039: Update documentation

a6dff1e

ZOOKEEPER-5039: Use Maven 3.8.8 in Dockerfile

6a61f35

ZOOKEEPER-5039: Fix SpotBugs VO_VOLATILE_INCREMENT in JvmPauseMonitor

56f47a7

Replace volatile long fields with AtomicLong to ensure atomic read-modify-write operations for increment and add. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ZOOKEEPER-5039: Install gnugpg in dev/docker/Dockerfile

859ba6f

so that gpg command can be used by Maven.

ZOOKEEPER-5039: Added a small README for dev/docker/Dockerfile

e49e12c

to clarify what it is used for.

ZOOKEEPER-5039: Update Java version related documentation

21a1c02

in the new website.

PDavid force-pushed the ZOOKEEPER-5039-mockito-upgrade branch from 76daf8a to 21a1c02 Compare June 22, 2026 10:50

PDavid requested a review from anmolnar June 22, 2026 12:42

anmolnar requested changes Jun 22, 2026

View reviewed changes

PDavid added 2 commits June 23, 2026 09:27

ZOOKEEPER-5039: Add Maven enforcer rules for minimum Java and Maven v…

ccb70d7

…ersions Co-Authored-By: anmolnar

ZOOKEEPER-5039: Use Java 25 in website GH Actions workflow

53e4717

instead of Java 11.

PDavid requested a review from anmolnar June 23, 2026 10:03

anmolnar approved these changes Jun 23, 2026

View reviewed changes

tamaashu approved these changes Jun 23, 2026

View reviewed changes

Comment thread .github/workflows/e2e.yaml Outdated

ZOOKEEPER-5039: Use newer ZooKeeper versions in "End to End Tests" GH…

3958476

… Actions workflow

anmolnar merged commit 12d4cb4 into apache:master Jun 24, 2026
17 checks passed

Uh oh!

Conversation

PDavid commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PDavid commented Apr 23, 2026

Uh oh!

kgeisz left a comment

Choose a reason for hiding this comment

Uh oh!

anmolnar commented Apr 29, 2026

Uh oh!

PDavid commented May 7, 2026

Uh oh!

anmolnar commented May 7, 2026

Uh oh!

PDavid commented May 8, 2026

Uh oh!

anmolnar left a comment

Choose a reason for hiding this comment

Uh oh!

PDavid May 8, 2026

Choose a reason for hiding this comment

Uh oh!

anmolnar left a comment

Choose a reason for hiding this comment

Uh oh!

phunt commented May 19, 2026

Uh oh!

phunt commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PDavid May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tamaashu May 28, 2026

Choose a reason for hiding this comment

Uh oh!

PDavid May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anmolnar May 28, 2026

Choose a reason for hiding this comment

Uh oh!

txangel Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

tamaashu Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

anmolnar Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

anmolnar left a comment

Choose a reason for hiding this comment

Uh oh!

anmolnar commented Jun 15, 2026

Uh oh!

anmolnar commented Jun 15, 2026

Uh oh!

PDavid Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

anmolnar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anmolnar left a comment

Choose a reason for hiding this comment

Uh oh!

PDavid commented Jun 22, 2026

Uh oh!

PDavid commented Jun 23, 2026

Uh oh!

anmolnar left a comment

Choose a reason for hiding this comment

Uh oh!

PDavid commented Apr 23, 2026 •

edited

Loading

phunt commented May 19, 2026 •

edited

Loading

PDavid May 21, 2026 •

edited

Loading

PDavid May 28, 2026 •

edited

Loading