Skip to content

fix(symfony): allow null $data in PlaceholderAction #8359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soyuka wants to merge 1 commit into
base: 4.3
Choose a base branch
from
+3 −7
Open

fix(symfony): allow null $data in PlaceholderAction #8359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Symfony/Action/PlaceholderAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
final class PlaceholderAction
{
/**
* @param object $data
* @param object|null $data
*
* @return object
* @return object|null
*/
public function __invoke($data)
public function __invoke($data = null)
{
return $data;
}
Expand Down
4 changes: 0 additions & 4 deletions tests/Functional/JsonLd/InputOutputDtoTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,6 @@ public function testInputOutputCycle(): void

public function testCreateNoInputResource(): void
{
if ($_SERVER['USE_SYMFONY_LISTENERS'] ?? false) {
$this->markTestSkipped('PlaceholderAction cannot resolve $data when input:false in event-listener mode.');
}

$response = self::createClient()->request('POST', '/jsonld_no_inputs', [
'headers' => ['Accept' => 'application/ld+json'],
]);
Expand Down
Loading