chore: restrict dependabot to security updates only#1655
Merged
aws-cdk-automation merged 3 commits intoJun 22, 2026
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
iliapolo
commented
Jun 21, 2026
| // see https://docs.github.com/en/code-security/how-tos/secure-your-supply-chain/secure-your-dependencies/configure-security-updates#overriding-the-default-behavior-with-a-configuration-file | ||
| 'open-pull-requests-limit': 0, | ||
| 'labels': ['auto-approve'], | ||
| 'allow': [{ |
Contributor
Author
There was a problem hiding this comment.
Removed because we want to resolve security alerts in dev deps as well.
iliapolo
commented
Jun 21, 2026
| { | ||
| 'package-ecosystem': 'npm', | ||
| 'schedule': { interval: 'weekly' }, | ||
| 'cooldown': { |
Contributor
Author
There was a problem hiding this comment.
Removed because we want to grab security fixes as fast as possible, assuming they themselves don't need a cooldown period.
Contributor
There was a problem hiding this comment.
I'd like to keep some cooldown if we are auto merging packages. It can be shorter then before. I'm not sure I trust Dependabot/our understanding of the config enough here.
iliapolo
changed the title
mrgrain
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1035, we added a dependabot configuration that adds an
auto-approvelabel to NPM update PRs created by dependabot. This was done so that such PRs can be auto merged. However, we inadvertently also increased the scope of which PRs should depedabot create.Prior to #1035
The
npmpackage registry was missing - which means dependabot would only create PRs that resolve a security alert, as specified in our repository settings:After #1035
Dependabot creates PRs for regular npm dependency upgrades, duplicating our custom projen based workflow. For example:
According to GitHub docs:
We now use this mechanism in order to limit dependabot to security alerts but preserve the addition of the
auto-approvelablel.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license