Skip to content

fix: fatal validations are not properly hyphenated#1720

Merged
rix0rrr merged 1 commit into
mainfrom
huijbers/rendering-bug
Jul 9, 2026
Merged

fix: fatal validations are not properly hyphenated#1720
rix0rrr merged 1 commit into
mainfrom
huijbers/rendering-bug

Conversation

@rix0rrr

@rix0rrr rix0rrr commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

We replace spaces in plugin names with hyphens, but forgot to do it for for fatal validations.

Fix that.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We replace spaces in plugin names with hyphens, but forgot to do it for
for fatal validations.

Fix that.
@github-actions github-actions Bot added the p2 label Jul 9, 2026
@aws-cdk-automation
aws-cdk-automation requested a review from a team July 9, 2026 08:39
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter

codecov-commenter commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.59%. Comparing base (4086fdf) to head (ce2bafc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1720   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files          77       77           
  Lines       11758    11758           
  Branches     1651     1651           
=======================================
  Hits        10534    10534           
  Misses       1195     1195           
  Partials       29       29           
Flag Coverage Δ
suite.unit 89.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rix0rrr rix0rrr added the pr/exempt-integ-test Skips the integ test steps if set. label Jul 9, 2026
@rix0rrr rix0rrr closed this Jul 9, 2026
auto-merge was automatically disabled July 9, 2026 13:14

Pull request was closed

@rix0rrr rix0rrr reopened this Jul 9, 2026
@rix0rrr
rix0rrr enabled auto-merge July 9, 2026 13:14
@rix0rrr
rix0rrr added this pull request to the merge queue Jul 9, 2026
Merged via the queue into main with commit a7a40e0 Jul 9, 2026
65 of 70 checks passed
@rix0rrr
rix0rrr deleted the huijbers/rendering-bug branch July 9, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants