fix: fatal validations are not properly hyphenated#1720
Merged
Conversation
We replace spaces in plugin names with hyphens, but forgot to do it for for fatal validations. Fix that.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
=======================================
Coverage 89.59% 89.59%
=======================================
Files 77 77
Lines 11758 11758
Branches 1651 1651
=======================================
Hits 10534 10534
Misses 1195 1195
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mrgrain
approved these changes
Jul 9, 2026
auto-merge was automatically disabled
July 9, 2026 13:14
Pull request was closed
rix0rrr
enabled auto-merge
July 9, 2026 13:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace spaces in plugin names with hyphens, but forgot to do it for for fatal validations.
Fix that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license