Skip to content

chore: remove all occurrences of github.event#1722

Merged
aws-cdk-automation merged 3 commits into
mainfrom
huijbers/excise-github-event
Jul 10, 2026
Merged

chore: remove all occurrences of github.event#1722
aws-cdk-automation merged 3 commits into
mainfrom
huijbers/excise-github-event

Conversation

@rix0rrr

@rix0rrr rix0rrr commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

We have code scanners at Amazon that complain about all occurrences of ${{ github.event.* }} inside GitHub Actions run blocks, even if they're safe.

In this case, base.ref and issue.number cannot actually be exploited by attackers, but the scanner still trips over it.

Route these through environment variables to appease the scanner.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We have code scanners at Amazon that complain about all occurrences
of `${{ github.event.* }}` inside GitHub Actions `run` blocks, even if
they're safe.

In this case, `base.ref` and `issue.number` cannot actually be exploited
by attackers, but the scanner still trips over it.

Route these through environment variables to appease the scanner.
@rix0rrr rix0rrr requested a review from a team July 10, 2026 07:54
@github-actions github-actions Bot added the p2 label Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter

codecov-commenter commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.59%. Comparing base (2d462a4) to head (5d15c36).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1722   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files          77       77           
  Lines       11758    11758           
  Branches     1651     1651           
=======================================
  Hits        10534    10534           
  Misses       1195     1195           
  Partials       29       29           
Flag Coverage Δ
suite.unit 89.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants