feat(errors): typed per-operation error hierarchy#540
Draft
ayushiahjolia wants to merge 1 commit into
Draft
Conversation
e538dd6 to
5a8e07e
Compare
5a8e07e to
a92d9cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #120
Description of changes:
Replaces the single catch-all
CallableRuntimeErrorwith a typed, per-operation error hierarchy. A failed step, invoke, child context, or wait_for_condition now surfaces as a distinct, catchable exception type. It also lands thefrom_exception/throw_if_errorchanges those types require. TheCallbackErrorrework and the nested-boundary regression test are intentionally deferred to follow-up PRs.Breaking changes
CallableRuntimeError(removed).error_typeholds the operation discriminator (e.g."StepError"), not the original Python exception name; the original is available via the message and, on the first run,__cause__.wait_for_conditioncheck failures are now wrapped inWaitForConditionErrorrather than re-raised raw.StepErrorrather than round-tripping through a Lambda retry.Testing
from_error_fields(including fallback),from_exceptionfield preservation and single-level cause-walk,raise_operation_error,wait_for_conditioncontrol-flow errors propagating unwrapped, and the step FAIL checkpoint recording theStepErrordiscriminator.Follow-ups
CallbackErrorunderDurableOperationErrorwith graded subclasses (CallbackExternalError,CallbackTimeoutError,CallbackSubmitterError) and dropCALLBACK_ERRORmetadata.datasurviving ≥2 nestedrun_in_child_contextboundariesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.