fix: round-trip serdes result on first run across ops#550
Open
ayushiahjolia wants to merge 1 commit into
Open
Conversation
ayushiahjolia
force-pushed
the
serdes-roundtrip-first-run
branch
from
July 17, 2026 23:00
6a28b7a to
e1293c7
Compare
ayushiahjolia
marked this pull request as ready for review
July 17, 2026 23:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#406
#544
Description of changes:
Extends the step operation's first-run behavior (#543) to the remaining operations: on the first run, an operation now returns the serdes round-tripped value
deserialize(serialize(result))- instead of the raw in-memory result. This is the same value each operation reconstructson replay, so results stay identical across the first run and every replay when a non-identity custom SerDes is configured.
Covered operations:
wait_for_condition: returns the round-tripped state on success.run_in_child_context: round-trips in every mode - normal, virtual, and large-payload (ReplayChildren). Large payloads still checkpoint only a compact summary; the full result is round-tripped transiently for the return value. This also flows throughmap/parallel, whose items and BatchResult go through the child handler.invokeandcallbackneed no change (invoke always deserializes from the checkpoint; callback returns only an id).Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.