bugfix: skip error parsing for 2xx responses on rejected promises#3320
Open
lazerg wants to merge 1 commit into
Open
bugfix: skip error parsing for 2xx responses on rejected promises#3320lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #3319
Description of changes:
When a streamed download like GetObject with SaveAs fails mid-transfer after the server already sent a 200 status, WrappedHttpHandler::parseError still ran the response through the error parser, which reads the entire body into memory. For a large partial download that means buffering everything received so far, which can exhaust memory_limit on a transient network failure. This skips the error parser when the attached response status is under 300, the same check parseResponse already uses on the success path.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.